Avi Kivity
Avi Kivity
Patches are welcome!
Looks good, very readable series. I'm worried that the long vectors/sorts will be problematic on large tables. But this is not new with the series, we'll need a pass to...
Please decorate the cover letter with results of testing at scale.
How long does the test take to run?
> Please decorate the cover letter with results of testing at scale. Still missing
> > > Please decorate the cover letter with results of testing at scale. > > > > > > Still missing > > @avikivity @tgrabiec Botond suggested that we...
> scale test result: > > multiple cycles of splits and merges, to 128 tablets back to 64. > >   > > ``` > $ for i in...
> > > scale test result: > > > multiple cycles of splits and merges, to 128 tablets back to 64. > > >   > > > ```...
Index seems wrong, we should pass some interface that one can call methods on.
> So instead of: > > ``` > connection(http_server& server, connected_socket&& fd, bool tls, int listener_idx) > ``` > > something like: > > ``` > struct listener_opaque { >...