Avi Kivity

Results 1240 comments of Avi Kivity

Looks good, very readable series. I'm worried that the long vectors/sorts will be problematic on large tables. But this is not new with the series, we'll need a pass to...

Please decorate the cover letter with results of testing at scale.

How long does the test take to run?

> Please decorate the cover letter with results of testing at scale. Still missing

> > > Please decorate the cover letter with results of testing at scale. > > > > > > Still missing > > @avikivity @tgrabiec Botond suggested that we...

> scale test result: > > multiple cycles of splits and merges, to 128 tablets back to 64. > > ![image](https://private-user-images.githubusercontent.com/1409139/389128739-f603b4a9-b36c-444d-bd1e-8bc7c661e1e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzI0NTgzODksIm5iZiI6MTczMjQ1ODA4OSwicGF0aCI6Ii8xNDA5MTM5LzM4OTEyODczOS1mNjAzYjRhOS1iMzZjLTQ0NGQtYmQxZS04YmM3YzY2MWUxZTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTEyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDExMjRUMTQyMTI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWQ0MjFhYWQzNDg0OTFlMmVlYjc0ZWFlMjliMTYwMGJlNjIxNzAzMDMzZjRjN2E4NjljYTY2YWU4YjNmMzQ2ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.-WSyoq88W3KqtrsFgsw-wOrT23Udjpb6ibgVuRKKj68) ![image](https://private-user-images.githubusercontent.com/1409139/389132266-fc77ad14-0fd7-41aa-a435-32fa82cd5bf3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzI0NTgzODksIm5iZiI6MTczMjQ1ODA4OSwicGF0aCI6Ii8xNDA5MTM5LzM4OTEzMjI2Ni1mYzc3YWQxNC0wZmQ3LTQxYWEtYTQzNS0zMmZhODJjZDViZjMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTEyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDExMjRUMTQyMTI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTVhYjZmZGQxNjIzOTczMTczMjZmODA0ODBjYWNmNTU5NWJjOTUxNGJhM2I0OTc2MGJhNmIyZTE5OTc4NDQ2NCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.KmD697bmC60okrlCDzIHEmy6obPQOTTcZBC_2sVDxOE) > > ``` > $ for i in...

> > > scale test result: > > > multiple cycles of splits and merges, to 128 tablets back to 64. > > > ![image](https://private-user-images.githubusercontent.com/1409139/389128739-f603b4a9-b36c-444d-bd1e-8bc7c661e1e1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzI0NTgzODksIm5iZiI6MTczMjQ1ODA4OSwicGF0aCI6Ii8xNDA5MTM5LzM4OTEyODczOS1mNjAzYjRhOS1iMzZjLTQ0NGQtYmQxZS04YmM3YzY2MWUxZTEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTEyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDExMjRUMTQyMTI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OWQ0MjFhYWQzNDg0OTFlMmVlYjc0ZWFlMjliMTYwMGJlNjIxNzAzMDMzZjRjN2E4NjljYTY2YWU4YjNmMzQ2ZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.-WSyoq88W3KqtrsFgsw-wOrT23Udjpb6ibgVuRKKj68) ![image](https://private-user-images.githubusercontent.com/1409139/389132266-fc77ad14-0fd7-41aa-a435-32fa82cd5bf3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzI0NTgzODksIm5iZiI6MTczMjQ1ODA4OSwicGF0aCI6Ii8xNDA5MTM5LzM4OTEzMjI2Ni1mYzc3YWQxNC0wZmQ3LTQxYWEtYTQzNS0zMmZhODJjZDViZjMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTEyNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDExMjRUMTQyMTI5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTVhYjZmZGQxNjIzOTczMTczMjZmODA0ODBjYWNmNTU5NWJjOTUxNGJhM2I0OTc2MGJhNmIyZTE5OTc4NDQ2NCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.KmD697bmC60okrlCDzIHEmy6obPQOTTcZBC_2sVDxOE) > > > ```...

Index seems wrong, we should pass some interface that one can call methods on.

> So instead of: > > ``` > connection(http_server& server, connected_socket&& fd, bool tls, int listener_idx) > ``` > > something like: > > ``` > struct listener_opaque { >...