avih

The commits add (and update) `.DS_Store`, is that intentional? (should we add it to `.gitignore`?)

> I think I removed them all in the final commit, no? I didn't look at the commits one by one, but assuming you intend to keep the commits incremental...

Not necessary to squash them right away, depends on how you want to present it - incremental changes or one commit which changes over time. But you can do that...

There are no hard rules, but the convention is that you can force push in a PR (change existing commits), but preferably keep a set of commits which is intended...

You give very little info, and no code. No one can help you like this. > Sometimes `wid` is negative. We noticed this behavior on long-running machines (some machines have...

> if (w32->opts->WinID >= 0) Right, so it's not taken from the option (and therefore embedding is disabled) if it's negative as 64 bits integer. Additionally, the win32 code in...

> 357500724, -797637628, -1665923796, 5572158 FWIW, all these values fit in signed 32 bit int. > int64_t wid = this->winId(); So you didn't follow the docs, which state to use...

> I get something like `18446744072911913988` Interesting, in hex it's `FFFFFFFFD0750404`, so the upper 32 bits are all 1. It doesn't look random, but I don't really know how HWND...

So far the issue looks like this: - HWND and all handles are 32 bits. - Windows acceps sign-extended values of any 32 bit values as valid (which are negative...

> So, are we going to just update the example or to try somehow solving this on the mpv side? Let's first confirm the solution. After that, assuming it works...