David Dale comments

Results 74 comments of


                                            David Dale

Natively support SONAR text models as M2M100 encoder and decoder models

Still planning to return to it

Natively support SONAR text models as M2M100 encoder and decoder models

Hi @amyeroberts! The PR is mostly ready for the review. I am still uncertain about several things, but I would appreciate if you commented on the current design! One of...

Natively support SONAR text models as M2M100 encoder and decoder models

Also tagging @ArthurZucker as a potential reviewer

Natively support SONAR text models as M2M100 encoder and decoder models

Tagging @ArthurZucker, @younesbelkada, and @amyeroberts once more, as potential reviewers. Could you please give some feedback?

Natively support SONAR text models as M2M100 encoder and decoder models

@ArthurZucker any other comments? What do you think about my responses?

Natively support SONAR text models as M2M100 encoder and decoder models

Hi @ArthurZucker! I have responded to your last comments. Some tests are failing, but they all seem to be unrelated to my code.

Natively support SONAR text models as M2M100 encoder and decoder models

@ArthurZucker do you think this PR has a chance?

Natively support SONAR text models as M2M100 encoder and decoder models

What exactly am I supposed to do with `modular` approach here? My guess is that you suggest creating a "modular" `sonar` directory that imports some code from `m2m100`, instead of...

Natively support SONAR text models as M2M100 encoder and decoder models

Hi @danikhan632! This PR grew very stale; I think it might need a complete rewriting from scratch. I might return to it nearer to the end of the year, but...

Include Kirundi (Rundi - run_Latn) language in the No Language Left Behind (NLLB) project

Hi @labKnowledge! First, Rundi is actually present in the NLLB-200 model. Please take a look [at the NLLB paper](https://arxiv.org/abs/2207.04672), where `run_Latn` is included in the language list on page 15....