unidecode icon indicating copy to clipboard operation
unidecode copied to clipboard

Feature Request: Add ability to set custom replacements

Open atlowell-smpl opened this issue 5 years ago • 4 comments

This is a feature request to add a library function that can be called to set custom character replacement mappings. The library function could be called in a similar manner to as follows:

unidecode.setReplacement('™', "(TM)")

after which subsequent calls to unidecode would replace '™' with '(TM)' rather than the default of "(tm).

For my particular use case, this would be useful for standardizing names across data sources. For instance, if one source has the name "Acme™" and the other has the name "Acme", I could make a call to replace all instances of '™' with "", which allows me to easily compare across sources.

However, I could see a large number of other use cases for this as well. For example, in the FAQ, it is mentioned that localization is not supported and that certain german characters translate to english text rather than german phonetics. Having a call like this could allow programmers to make their own "localization" libraries, allowing them to whatever mappings they feel like.

atlowell-smpl avatar Mar 25 '20 22:03 atlowell-smpl

I would love this. I'd love to be able to replace something like: [?] with an empty space instead.

youssefavx avatar May 27 '20 21:05 youssefavx

I think @atlowell-smpl's use case is something that falls outside of Unidecode's concern. It's easy to do such string replacements yourself before a call to Unidecode.

I agree that the characters that get replaced with a [?] are a problem. It's something that #53 already tried to address (reading my comments there I think I initially misunderstood the goal of that pull request).

Before code for that can be added the character tables first need to be updated and unknown characters marked (probably with None instead of [?])

avian2 avatar May 28 '20 07:05 avian2

I've implemented the feature to specify custom replacement strings for characters that are unknown to Unidecode. For example, this will use ASCII space to replace characters that are not are not present in Unidecode's tables.

>>> unidecode('[\ue000]', errors='replace', replace_str=' ')
[ ]

avian2 avatar Jan 08 '21 15:01 avian2

Hacky way to do this:

from typing import cast


def assert_not_none(var: _T | None) -> _T:
    """
    Assert the ``var`` is not None and return it.
    
    This will remove ``| None`` from type ``_T``.
    """
    assert var is not None
    return var


def add_custom_replacement(find: str, replace: str) -> None:
    from unidecode import Cache, unidecode  # noqa: PLC0415
    unidecode(find)  # Force it to load the module
    codepoint = ord(find)
    section = codepoint >> 8
    position = codepoint % 256
    new_section = cast(list[str | None],
                       (Cache[section] if isinstance(Cache[section], list) else
                        (list(assert_not_none(Cache[section])) if Cache[section] is not None else
                         [None for _ in range(position + 1)])))  # convert to mutable type
    assert len(new_section) > position
    new_section[position] = replace
    Cache[section] = new_section

Edit: made it type-safe.

Tatsh avatar Sep 28 '24 23:09 Tatsh