Hebrew icon indicating copy to clipboard operation
Hebrew copied to clipboard

Fix Types. Fix `adding Hebrew objects` bug

Open dickermoshe opened this issue 2 years ago β€’ 1 comments

Type of changes

  • [x] πŸ› Bug fix
  • [ ] 🎁 New feature
  • [ ] πŸ“„ Documentation / docstrings
  • [ ] πŸ§ͺ Tests
  • [ ] Other

Checklist

  • [x] πŸ’» I've run the latest black with default args on new code.
  • [x] πŸ§ͺ I've added tests for new code.
  • [x] βœ”οΈ I ran pytest with the --codeblocks flag to ensure that my changes are compatible with the codeblocks found in the documentation.
  • [x] πŸ•΅οΈ I accept that @avi-perl may be pedantic (just a little) in the code review.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

dickermoshe avatar Dec 11 '23 18:12 dickermoshe

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (323811f) 100.00% compared to head (55af18e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        13    -1     
  Lines          939       942    +3     
=========================================
+ Hits           939       942    +3     
Flag Coverage Ξ”
unittests 100.00% <100.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 11 '23 18:12 codecov-commenter