RustQuant icon indicating copy to clipboard operation
RustQuant copied to clipboard

Unify `ml` input data type to one interface

Open aatmunbaxi opened this issue 2 years ago • 3 comments

Many ml algorithms use a similar (or verbatim) same type of input. i.e. a matrix X that has samples along the rows with each column being a certain feature of the data, and column vector y that has labels indicating what class each sample belongs to in the case of classification, or output points in the case of regression.

To avoid rewriting the handling of this data for every ml module, maybe we can make a single interface (maybe MLInput?) that stores this information and is used as an input for the ml modules?

aatmunbaxi avatar Oct 09 '23 18:10 aatmunbaxi

I'm working on a draft of such an interface. See here for an idea of what it looks like.

aatmunbaxi avatar Oct 11 '23 15:10 aatmunbaxi

I agree, makes sense to have one interface for all of them.

avhz avatar Oct 11 '23 20:10 avhz

Just a heads up, I have unpacked the ml sub-directories, as it is not a very big module yet so the extra folders are not necessary imo.

avhz avatar Oct 11 '23 21:10 avhz