awesome-go icon indicating copy to clipboard operation
awesome-go copied to clipboard

Add https://github.com/xeptore/flaw package

Open xeptore opened this issue 1 year ago • 1 comments

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

  • repo link (github.com, gitlab.com, etc): https://github.com/xeptore/flaw
  • pkg.go.dev: https://pkg.go.dev/github.com/xeptore/flaw
  • goreportcard.com: https://goreportcard.com/report/github.com/xeptore/flaw
  • coverage service link (codecov, coveralls, etc.):

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below that apply before you submit PR. Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • [x] The package has been added to the list in alphabetical order.
  • [x] The package has an appropriate description with correct grammar.
  • [x] As far as I know, the package has not been listed here before.
  • [x] The repo documentation has a pkg.go.dev link.
  • [ ] The repo documentation has a coverage service link.
  • [ ] The repo documentation has a goreportcard link.
  • [x] The repo has a version-numbered release and a go.mod file.
  • [x] I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • [ ] The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • [ ] Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Thanks for your PR, you're awesome! :+1:

xeptore avatar Dec 25 '23 06:12 xeptore

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • godoc.org or pkg.go.dev
  • goreportcard.com
  • coverage

your project is about to be approved, it's under revision, it may take a few days

github-actions[bot] avatar Dec 25 '23 06:12 github-actions[bot]

@xeptore Why is this PR still on draft? Do you need some help?

cassiobotaro avatar Jan 27 '24 18:01 cassiobotaro

Looking for spare time to update the repo, and mark remaining check boxes, @cassiobotaro.

xeptore avatar Jan 27 '24 19:01 xeptore

Forgive me for being blunt but how come you're already at v8 when no one is using your library.

phanirithvij avatar Mar 09 '24 15:03 phanirithvij

Forgive me for being blunt but how come you're already at v8 when no one is using your library.

* no one publicly maybe?

Also, where can I find out users of a specific package beside the "imported by" section in pkg.go.dev, @phanirithvij?

xeptore avatar Mar 09 '24 18:03 xeptore

If no one publicly is using it then I suggest submitting the project again later when there are some. If it is only privately used does it belong in a public awesome-go list?

I looked at the imported by field like you said. I don't know of any other places. And I looked the near-zero content in the readme. And the low amount of interest in the project since its initial commit 7 months ago. (In the form of open issues, prs and stars/bookmarks to your project)

If you are trying to be in the spirit of awesome I suggest again resubmitting later on when it is actually awesome and you follow the full pr template. I see this is a draft pr but please reopen a PR only after you're done with the changes you said you'd make when you have time.

Please note that I have no intention of personally targeting you or your project but I am simply stating what I see. I apologise if I have offended you.

I will leave this open and let @cassiobotaro handle this pr merging but I am against it in this state.

As I said multiple times I strongly suggest resubmitting after polishing it a lot further.

phanirithvij avatar Mar 09 '24 22:03 phanirithvij

If you are trying to be in the spirit of awesome I suggest again resubmitting later on when it is actually awesome and you follow the full pr template.

OK, I got the point. Closing.

xeptore avatar Mar 10 '24 04:03 xeptore