awesome-go icon indicating copy to clipboard operation
awesome-go copied to clipboard

add iCache

Open mdaliyan opened this issue 2 years ago • 2 comments

Repo link on https://github.com/mdaliyan/icache added in the correct section

Make sure that you've checked the boxes below that apply before you submit PR.

  • [x] The package has been added to the list in alphabetical order.
  • [x] The package has an appropriate description with correct grammar.
  • [x] As far as I know, the package has not been listed here before.
  • [x] The repo documentation has a pkg.go.dev link.
  • [x] The repo documentation has a coverage service link on coveralls.io.
  • [x] The repo documentation has a goreportcard link.
  • [x] The repo has a version-numbered release and a go.mod file.
  • [x] I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • [x] The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • [x] The authors of the project do not commit directly to the repo, but rather use pull requests that run the continuous-integration process. (Will do. Was not necessary so far because it was used only in the projects we had control over them. we decided to make it open source, so contribution will be through PRs from now on)

mdaliyan avatar Oct 06 '22 08:10 mdaliyan

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: False
  • coverage: True

your project is about to be approved, it's under revision, it may take a few days

avelino avatar Oct 06 '22 08:10 avelino

Not sure what you mean by goreportcard.com: False cause the link exists in the repo readme as a badge. Please tell me if anything is missing.

mdaliyan avatar Oct 07 '22 04:10 mdaliyan

Apologies, your pr was missed. and that github-actions comment isn't that reliable, but its output is not that important so no one has fixed it in years. might as well disable it imo.

phanirithvij avatar Jun 25 '24 03:06 phanirithvij