awesome-go icon indicating copy to clipboard operation
awesome-go copied to clipboard

Add sake to Other Software

Open alajmo opened this issue 2 years ago • 4 comments

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

  • repo link (github.com, gitlab.com, etc): https://github.com/alajmo/sake
  • pkg.go.dev: https://pkg.go.dev/github.com/alajmo/sake
  • goreportcard.com: https://goreportcard.com/report/github.com/alajmo/sake
  • coverage service link (codecov, coveralls, gocover etc.): I use integration tests mainly since it's a CLI tool that mainly interacts with remote servers. See https://github.com/alajmo/sake/tree/main/test

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below that apply before you submit PR. Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for detials.

  • [x] The package has been added to the list in alphabetical order.
  • [x] The package has an appropriate description with correct grammar.
  • [x] As far as I know, the package has not been listed here before.
  • [x] The repo documentation has a pkg.go.dev link.
  • [ ] The repo documentation has a coverage service link.
  • [x] The repo documentation has a goreportcard link.
  • [x] The repo has a version-numbered release and a go.mod file.
  • [x] I have read the Contribution Guidelines, Maintainers Note and Quality Standards.
  • [x] The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • [x] The authors of the project do not commit directly to the repo, but rather use pull requests that run the continuous-integration process.

Thanks for your PR, you're awesome! :+1:

alajmo avatar Jun 14 '22 19:06 alajmo

Thank you for contributing with awesome-go, we will revise your contribution as soon as possible.

Automation body links content check:

  • godoc.org or pkg.go.dev: True
  • goreportcard.com: True
  • coverage: True

your project is about to be approved, it's under revision, it may take a few days

avelino avatar Jun 14 '22 19:06 avelino

This PR has been automatically marked as closed because it has not had recent activity. They will wait 15 days for your interaction, after that the PR will be closed. Please read more in https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md

github-actions[bot] avatar Jun 30 '22 00:06 github-actions[bot]

I understand, unfortunately, it's quite hard to do proper code coverage for this kind of project, since its main use is to run commands on remote servers and I found using docker containers and golden files (https://github.com/alajmo/sake/tree/main/test/integration/golden) a lot easier and less complex than creating SSH mocks. But I'll take this into consideration for the future and see if I can add code coverage later on.

On that note, you might want to remove my other contribution (mani, which also uses golden files) and another similar project to mine sup (which doesn't seem to have any tests at all).

alajmo avatar Jun 30 '22 16:06 alajmo

This PR has been automatically marked as stale because it has not had recent activity. They will wait 15 days for your interaction, after that the PR will be closed. Please read more in https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md

github-actions[bot] avatar Jul 16 '22 00:07 github-actions[bot]

This PR has been automatically marked as stale because it has not had recent activity. They will wait 15 days for your interaction, after that the PR will be closed. Please read more in https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md

github-actions[bot] avatar Aug 01 '22 00:08 github-actions[bot]