awesome-go icon indicating copy to clipboard operation
awesome-go copied to clipboard

GoReportCard is struggling with go 1.18 and golint

Open spekary opened this issue 2 years ago • 3 comments

GoReportCard's github is reporting the following:

Go 1.18 generics is not working in gofmt or golint

golint has been deprecated and is not likely to be fixed.

spekary avatar Mar 21 '22 16:03 spekary

GoReportCard has removed golint from its list of tools. I have recommended to them that they use staticcheck instead.

So, at this point in time, we will not be able to evaluate code quality with a linter unless we run it ourselves.

spekary avatar Mar 23 '22 18:03 spekary

@avelino how shall we handle this? GoReportCard currently has no linter. I have recommended that they move to golangci-lint.run. Should we start asking for an output of that, or set up our own golangci-lint.run, or just accept whatever goreportcard is producing for now?

spekary avatar Mar 31 '22 15:03 spekary

Sorry for the delay in answering

As GoReportCard does not yet support Go 1.8 (generic), we will disregard this iteM from the checklist and validate the others

GoReportCard is an open source project and this issue was opened there, we can contribute to it https://github.com/gojp/goreportcard/issues/381

As a second step we need to have our tools to depend as little as possible on third-party services

avelino avatar Apr 01 '22 22:04 avelino