avatar2
avatar2 copied to clipboard
Installer has invalid references to GitHub repos
Hey!
I have found several invalid references to GitHub repos while I was trying to install avatar2.
When I try to run python -m avatar2.installer
, most targets, that are available from the package manager, install without a problem, however, others exited when the installer had tried to clone the given repos.
After debugging a little, I found out that branches for the targets' repos have been changed!
Hi!
Thanks for reporting! Indeed, we have changed our development over to docker, and rarely use the installer these days. I see two ways forward:
- fixing the references and bringing the installer up to date
- Deprecating the installer and be more detailed about our dockerized setup
Personally, I would prefer (2), I think - unless someone wants to take over the installer feature. @rawsample what is your opinion?
Hello,
I agree with you, the docker approach is more robust and should be prioritize for targets installation. We can deprecate the installer. Nevertheless, bringing it up to date was not a huge effort. I will commit this soon.