pytest-docker icon indicating copy to clipboard operation
pytest-docker copied to clipboard

Published 20 hours ago • verified publisher icon avast

Fixed cleaning of messy output for port number.

Open langustav opened this issue 2 years ago • 5 comments

langustav avatar May 18 '22 08:05 langustav

Hello, thank you for the PR. Can you please provide more context for this change? For example, you are adding explicit ValueErrors ― what exceptions are raised right now? Should developers handle these exceptions in a special way? Also some tests would be nice.

Luminaar avatar Jul 28 '22 05:07 Luminaar

Sorry, I thought I have linked the issue here. But apparently not. So here it is: https://github.com/avast/pytest-docker/issues/78

langustav avatar Aug 29 '22 11:08 langustav

Any progress on this or any help needed? I came across this issue as well. Simple docker desktop installation on Windows 11

wickywaka avatar Sep 17 '22 19:09 wickywaka

@Luminaar can I help in order to get this one merged? Have you reviews the attached issues as explainer for the reasoning?

lbenka avatar Nov 03 '23 14:11 lbenka

I'm not sure this is safe, because the endpoint could IMHO contain something different than an IP address. What about removing weird characters instead?

augi avatar Jan 25 '24 10:01 augi