material-you-theme icon indicating copy to clipboard operation
material-you-theme copied to clipboard

Run wal on background change and use system sassc

Open daniromome opened this issue 2 years ago • 3 comments

Had a few issues getting the tweak to work with the sass installation button, I made it so it uses system-wide sassc and also added automatic run of pywal whenever background changes since pywal color schemes are supported by a handful of applications. Attaching screenshot of what kind of themes could these changes enable pywall-gnome

daniromome avatar Sep 15 '22 23:09 daniromome

Please update the readme and the install sass button in prefs (to install sassc and pywal or point to the githubs to install them)

ardjuh avatar Sep 16 '22 09:09 ardjuh

At a future moment, we can maybe generate a pywal theme and apply it, so it's more coherent with the rest of the theme and has better readability. image

ardjuh avatar Sep 16 '22 19:09 ardjuh

The way this PR checks if wal is installed will cause issues on certain systems because it only checks /usr/bin/wal. It assumes it's installed globally, when some users might install it in their user path. Even when I install it via pip3 with sudo it ends up in /usr/local/bin/wal on Fedora. I would suggest to check in $PATH

I would also suggest adding a check to see if wal should be ran with -l to potentially generate better color pallets for light mode.

aidanlw505 avatar Oct 10 '22 03:10 aidanlw505