Prevent specifying error type in `t.notThrows()`

[sindresorhus]

It's an easy mistake to make if you have many t.throws() statements and then some t.notThrows() statements.

For example: https://github.com/sindresorhus/p-queue/commit/80e8e25926a6632d0429ebb526ee78a68f01d565

// Fail
t.notThrows(() => {
 t.pass();
}, TypeError);

// Ok
t.notThrows(() => {
 t.pass();
});

It should fail if it's a variable matching this regex: /^(?:[A-Z][a-z0-9]*)*Error$/

---

IssueHunt Summary

Backers (Total: $60.00)

• issuehunt ($60.00)

Submitted pull Requests

• #240 rule prevent-errortype
• #326 Add no-error-ctor-with-notthrows rule

---

Become a backer now!

Or submit a pull request to get the deposits!

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

[sindresorhus]

@novemberborn In AVA, I think we should assert it's a string or undefined at runtime. What do you think?

[novemberborn]

@sindresorhus https://github.com/avajs/ava/issues/1125

[IssueHuntBot]

@issuehunt has funded $60.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[rahgurung]

@sindresorhus @novemberborn I tried to give it a shot please review and guide further. #240