ava icon indicating copy to clipboard operation
ava copied to clipboard

Examples now use AVA 4

Open Timethor opened this issue 3 years ago • 5 comments

Resolves #2993

  • I've updated some of the examples to "module", while others were left as "commonjs" ... thought it would be good to see both
  • Seemed like I needed a ava.config.js file for most examples (assuming this is for monorepo behavior mentioned in the ESM Support sections of 4.X releases). If there's a more preferred way please let me know and I'll update
  • Any new examples you'd like me to create for new v4 features, more than willing... still catching up, last used AVA when it was v1-v2

Timethor avatar Apr 27 '22 18:04 Timethor

@Timethor nice!

  • I've updated some of the examples to "module", while others were left as "commonjs" ... thought it would be good to see both

I suppose, but I don't think it's helpful to see a CommonJS test that then needs to use a dynamic import() for an ES module.

  • Seemed like I needed a ava.config.js file for most examples (assuming this is for monorepo behavior mentioned in the ESM Support sections of 4.X releases). If there's a more preferred way please let me know and I'll update

Ha, yes that makes sense actually. You could export default {} though, there shouldn't be a need to override any of the defaults.

  • Any new examples you'd like me to create for new v4 features, more than willing... still catching up, last used AVA when it was v1-v2

Hmm, I'm not sure how full the coverage of v3 features was. Let's assume 100% and then we could have a look at the changelog since?

novemberborn avatar May 02 '22 10:05 novemberborn

Hi @Timethor, would you have time to get back to this?

novemberborn avatar Jun 05 '22 17:06 novemberborn

Line number selection may no longer work in StackBlitz with AVA 4, see https://github.com/avajs/ava/issues/3049#issuecomment-1147390189. Source maps now come from Node.js and we're seeing https:// URLs which AVA isn't meant to deal with.

novemberborn avatar Jun 07 '22 13:06 novemberborn

@novemberborn Sorry, nearly forgot about this, been a crazy few months. Will be getting some spare time in a week or two 🙃

Timethor avatar Aug 24 '22 15:08 Timethor

No worries @Timethor!

novemberborn avatar Aug 25 '22 12:08 novemberborn

Closing due to inactivity. We'd be happy to pick this up again when you have the time to get back to this.

novemberborn avatar Oct 23 '22 13:10 novemberborn