AvaTax-REST-V2-Ruby-SDK icon indicating copy to clipboard operation
AvaTax-REST-V2-Ruby-SDK copied to clipboard

Published 20 hours ago • verified publisher icon avadev

Fix regex for filtering credentials from logs

Open starsirius opened this issue 3 years ago • 2 comments

The ending "=" character of a base64 encoded string is padding. When the input length is a multiple of three (which is the case for our account id and license key pair), the output would not have the padding character. This results in our credentials not being filtered in the logs.

This fixes the regex by removing the incorrect assumption.

starsirius avatar Aug 11 '21 21:08 starsirius

Looks like CI is no longer running and will need to migrate from travis-ci.org to travis-ci.com.

starsirius avatar Aug 11 '21 23:08 starsirius

@shilpakhanal I see you are the most recent contributor to this project. We're in the process of integrating the SDK with our app. Do you mind helping us get this PR reviewed and hopefully merged (or directing us to the right person/process)? Thank you! 🙏

starsirius avatar Aug 23 '21 14:08 starsirius