AvaTax-REST-V2-PHP-SDK icon indicating copy to clipboard operation
AvaTax-REST-V2-PHP-SDK copied to clipboard

Missing method to set $this->_model['email '] (Customer Email)

Open ScottishDarren opened this issue 1 year ago • 1 comments

The PHP class TransactionBuilder does not have a method to set the customer email.

The .NET class has this available: https://github.com/avadev/AvaTax-REST-V2-DotNet-SDK/blob/master/src/TransactionBuilder.cs

line 812:

public TransactionBuilder WithEmail(string email)
        {
            _model.email = email;
            return this;
        }

There is no equivalent method in the PHP class. To add this method, this file must be adjusted: https://github.com/avadev/AvaTax-REST-V2-PHP-SDK/blob/master/src/TransactionBuilder.php

Example code for new method:

    /**
     * Set a customer email
     *
     * @param   string              email
     * @return  TransactionBuilder
     */
    public function withEmail($email)
    {
        $this->_model['email'] = $email;
        return $this;
    }

ScottishDarren avatar Dec 15 '23 12:12 ScottishDarren

@ScottishDarren Feel free to create a PR for this if you'd like to add it, we would be happy to merge. Otherwise, we will address this time permitting. Thanks!

svc-developer avatar Jul 01 '24 21:07 svc-developer

Released in 24.8.2

svc-developer avatar Aug 30 '24 16:08 svc-developer