AvaTax-REST-V2-JS-SDK icon indicating copy to clipboard operation
AvaTax-REST-V2-JS-SDK copied to clipboard

Published 20 hours ago • verified publisher icon avadev

Regression: `timeout` is optional according to README but required by TypeScript

Open petrm-integromat opened this issue 1 year ago • 2 comments

This issue has been fixed once already in 23.8.1 but manifests again in 23.11.0. First reported in https://github.com/avadev/AvaTax-REST-V2-JS-SDK/issues/284

When creating new Avatax client instance using new Avatax({...}), I get a TypeScript error that the Property timeout is missing in the passed object but required by the constructor. In documentation it is marked as optional and in code I can see it has a default value. It's just the type that is wrong.

petrm-integromat avatar Nov 13 '23 13:11 petrm-integromat

Any update on this?

petrm-integromat avatar Feb 19 '24 07:02 petrm-integromat

@svc-developer please could you take a look at this?

petrm-integromat avatar Apr 26 '24 08:04 petrm-integromat

@petrm-integromat Yes will take a look here

svc-developer avatar Jul 01 '24 21:07 svc-developer

24.6.4 addresses this issue, thank you

svc-developer avatar Jul 03 '24 18:07 svc-developer