subnet-evm
subnet-evm copied to clipboard
Use require in unit tests
We should adopt require
package in our unit tests rather than using t.Fatal
or assert
. These are mainly in vm_test
file.
In AvalancheGo we use a golangci
config that forces using require
, we can force it here as well.
I can take a look
I can take a look
Much appreciated 🙌 . I assigned it to you
@morrisettjohn one thing to be careful here is to avoid modifying tests we take from upstream. We will want to be as textually similar to upstream in files shared with upstream.
Sounds good! I'll try to be careful not to modify those tests then