subnet-evm icon indicating copy to clipboard operation
subnet-evm copied to clipboard

Use require in unit tests

Open ceyonur opened this issue 1 year ago • 4 comments

We should adopt require package in our unit tests rather than using t.Fatal or assert. These are mainly in vm_test file.

In AvalancheGo we use a golangci config that forces using require, we can force it here as well.

ceyonur avatar Jun 27 '23 10:06 ceyonur

I can take a look

morrisettathena avatar Jun 27 '23 18:06 morrisettathena

I can take a look

Much appreciated 🙌 . I assigned it to you

ceyonur avatar Jun 28 '23 10:06 ceyonur

@morrisettjohn one thing to be careful here is to avoid modifying tests we take from upstream. We will want to be as textually similar to upstream in files shared with upstream.

darioush avatar Jun 28 '23 15:06 darioush

Sounds good! I'll try to be careful not to modify those tests then

morrisettathena avatar Jun 28 '23 16:06 morrisettathena