avash icon indicating copy to clipboard operation
avash copied to clipboard

Published 20 hours ago • verified publisher icon ava-labs

Minor code refactor and test cases

Open adasari opened this issue 4 years ago • 3 comments

adasari avatar Apr 19 '21 21:04 adasari

This is a great start, but we should probably be revamping the APIs used in avash to use the client in AvalancheGo instead. Ex. https://github.com/ava-labs/avalanchego/blob/master/vms/avm/client.go.

aaronbuchwald avatar Apr 27 '21 14:04 aaronbuchwald

This is a great start, but we should probably be revamping the APIs used in avash to use the client in AvalancheGo instead. Ex. https://github.com/ava-labs/avalanchego/blob/master/vms/avm/client.go.

@aaronbuchwald Client wrapper looks good. Shall i go ahead use client instead of explicit api calls ? if yes, what would be the output of the command(s) ? remains same or print all details of response struct ?

adasari avatar Apr 27 '21 18:04 adasari

@aaronbuchwald @cgcardona - Replaced API calls with avm client for avawallet cmd and also added testcases. please take a look.

adasari avatar Apr 27 '21 22:04 adasari