avalanchego
avalanchego copied to clipboard
Introduce ShortNodeID
Why this should be merged
This PR is the first step toward ACP-20.
The existing NodeID
was renamed into ShortNodeID
, and a new, backward compatible NodeID
was added.
Given that the ACP-20 changes are expected to be massive, I'd like to merge this backward-compatible change
before moving with the rest of the changes.
How this works
For most of the places, the usages of NodeID
would remain as is.
Places that need to retain the classic NodeID
were modified to be using the ShortNodeID
.
The change is expected to be in a single direction only. i.e. ShortNodeID
can be converted into NodeID
by calling it's NodeID()
function. No conversion from NodeID
to ShortNodeID
should be needed.
How this was tested
Tested against existing unit tests.