avalanchego icon indicating copy to clipboard operation
avalanchego copied to clipboard

ban usage of `require.Equal` when testing for errors

Open dhrubabasu opened this issue 1 year ago • 4 comments

Why this should be merged

How this works

How this was tested

dhrubabasu avatar May 13 '23 21:05 dhrubabasu

I feel like we shouldn't be merging this until (at least after) we enable the goerr113 linter. Currently - there are a number of parts of our code that do rely on error equality - and this may allow future incorrect changes to pass CI.

StephenButtolph avatar May 30 '23 17:05 StephenButtolph

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

github-actions[bot] avatar Jul 02 '23 00:07 github-actions[bot]

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

github-actions[bot] avatar Sep 10 '23 00:09 github-actions[bot]

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

github-actions[bot] avatar Mar 24 '24 00:03 github-actions[bot]