Liquid-Application-Framework-1.0-deprecated icon indicating copy to clipboard operation
Liquid-Application-Framework-1.0-deprecated copied to clipboard

Published 20 hours ago • verified publisher icon ava-innersource

ILightModel.id should follow coding standards

Open bruno-brant opened this issue 5 years ago • 1 comments

There's an id property in ILightModel that is all in lowercase:

https://github.com/Avanade/Liquid-Application-Framework/blob/1f805007f58b73ae09067bc56f863ae0fa702224/src/Liquid.Base/Interfaces/Repository/ILightModel.cs#L5

The coding standards for C# calls for UpperCamelCase (PascalCase) in every public property.

I guess the reason for this has to do with storage or JSON formatting. This should be solved through configuration, not by bending the code. This would imply that we can't follow standards in any model at all.

bruno-brant avatar Nov 25 '19 15:11 bruno-brant

Marking it as an enhancement since this doesn't result in runtime errors.

bruno-brant avatar Nov 25 '19 15:11 bruno-brant