Liquid-Application-Framework-1.0-deprecated icon indicating copy to clipboard operation
Liquid-Application-Framework-1.0-deprecated copied to clipboard

Published 20 hours ago • verified publisher icon ava-innersource

Correct translation of word "critic"

Open bruno-brant opened this issue 4 years ago • 0 comments

The term Critic is used throughout Liquid's code (Critic, ICriticHandler, etc.):

https://github.com/Avanade/Liquid-Application-Framework/blob/1f805007f58b73ae09067bc56f863ae0fa702224/src/Liquid.Base/Interfaces/CriticHandler/ICritic.cs#L10

This is a literal translation of the word in portuguese ("crítica"). The intent of the developer, I believe, was to talk about issues or problems in a request or objects that are identified during processing or validation.

The word in english means a person whose job is to appraise the work of others, as it can be seen in multiple dictionaries:

  • https://en.wiktionary.org/wiki/critic
  • https://www.merriam-webster.com/dictionary/critic?src=search-dict-hed

~~I'm calling this a bug since there's a certain urgency in fixing it before Liquid can be adequately used internationally.~~

Tagged it as a spelling issue.

bruno-brant avatar Oct 29 '19 20:10 bruno-brant