Liquid-Application-Framework-1.0-deprecated icon indicating copy to clipboard operation
Liquid-Application-Framework-1.0-deprecated copied to clipboard

Published 20 hours ago • verified publisher icon ava-innersource

Review "Polly" approach

Open bruno-brant opened this issue 5 years ago • 1 comments

Polly is a resilience library for .NET. It was somewhat coupled to Liquid (the name of the interface is ILightPolly, for instance).

Right now, for some unknown reason, WorkBench.Polly is different to other cached services, in that Polly is a public property, and it is written to by UseBase:

https://github.com/Avanade/Liquid-Application-Framework/blob/f2b5da239bd9f411386344053989609abcb4f1ce/src/Liquid.Middleware/UseBase.cs#L78

Well, that's a bit strange. It seems that all the protections of other services, such as not being able to set them twice, is lost...

We should rethink this approach.

bruno-brant avatar Dec 13 '19 21:12 bruno-brant