visage icon indicating copy to clipboard operation
visage copied to clipboard

improve sub URI deployment / docs / other tweaks

Open ramcq opened this issue 13 years ago • 2 comments

Nothing groundbreaking here, just some tweaks I did to get up and running this weekend. Thought I should share the sub URI fixes and update the documentation as it took me a while to coax into life. Hopefully it doesn't break the non sub-URI case... :)

The changes to graph.js are fairly pointless but they allow a simple place in the code for me to hack in appearance changes depending on the graph being drawn. I've got a current monitoring device hooked up to collectd (http://thread.gmane.org/gmane.comp.monitoring.collectd/4479) where the graphs really make a lot more visual sense when the readings are stacked:

    if (this.options.plugin.test(/^currentcost-/)) {
      options.chart.defaultSeriesType = 'area';
      options.colors = ['#F08080','#EEE8AA','#ADD8E6'];
    }

I think a lot of other data types like memory, CPU, networking, etc are amenable to stacked graphing too so if you've got some good ideas how to match/implement cleanly I'd be happy to have a go at a patch.

ramcq avatar Apr 26 '11 00:04 ramcq

This looks pretty great!

I'm of two minds about the specific colour schemes though. On one hand, it makes the colours inconsistent with the rest of the rendered graphs, and on the other they look pretty sweet. :-)

What do you think?

It's a bit of an ask, but have you tested these colours for people with trichromacy colour blindness? Totally ok if you haven't, I'm just curious about if these colours are any better than the Visage/Highcharts defaults.

auxesis avatar Apr 29 '11 23:04 auxesis

Please commit the changes regarding sub URIs... On many machines I don't have a spare IP / domain to dedicate to a VirtualHost and need to use sub URIs.

Note that since these changes a few other files need to be changed, namely the 'data' callback location in the JavaScript files is hardcoded and doesn't get prefixed.

stewartadam avatar Mar 17 '13 04:03 stewartadam