ASBPlayerSubtitling icon indicating copy to clipboard operation
ASBPlayerSubtitling copied to clipboard

Published 20 hours ago • verified publisher icon autresphere

Feature - loadWebVTTSubtitlesAtURL

Open allenlinli opened this issue 6 years ago • 3 comments

Add new function - (void)loadWebVTTSubtitlesAtURL:(NSURL *)url error:(NSError **)error, so ASBPlayerSubtitling.h accepts WebVTT.

Re-install pod to make project compilable.

allenlinli avatar May 28 '18 09:05 allenlinli

Hi @autresphere I wonder if this PR is ok now? I removed the part of PR that change the original API, it should be ok now.

allenlinli avatar Jul 16 '18 09:07 allenlinli

Hi @allenlinli, this looks really good, thanks a lot! There is now an issue with Travis CI, I guess the test command is too old and should be updated. Would you be kind enough to update it? I don't have time to have a look at it before several weeks.

autresphere avatar Jul 16 '18 16:07 autresphere

I probably cannot fix Travis CI when I on work, I want to have a look when I am off work. I have no experience with Travis CI. Where can I edit the Travis CI shell script?

allenlinli avatar Jul 17 '18 09:07 allenlinli