autoware
autoware copied to clipboard
chore(docker): change the cmake's build tool from `make` to `ninja`
Description
This PR has changed the cmake's build tool from make to ninja.
ninja is typically faster than make to rebuild modified source code.
So when using cache properly, the ninja build time would be faster than make.
https://ninja-build.org/
The results of the colcon build time using my local PC are shown below. There may be a few overhead.
make: 40min 59.55sninja: 41min 57.07s
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
- [x] I've confirmed the contribution guidelines.
- [x] The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
- [ ] The PR follows the pull request guidelines.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
- [ ] There are no open discussions or they are tracked via tickets.
After all checkboxes are checked, anyone who has write access can merge the PR.
~Temporalily https://packages.microsoft.com/ubuntu/22.04/prod/dists/jammy/InRelease has no response. That's why setup-docker and setup-universe CI checks were failed.~
Resolved.
Is ninja installed on the system? Could you share the step that installs it?
I couldn't find the step so that I've explicitly installed ninja-build.
https://github.com/autowarefoundation/autoware/pull/4658/commits/158ff39afaf68a076fd76df53d2dbccb35bf74e2
@xmfcx Please review again.
@youtalk -san, why was this closed?
@xmfcx Just no reason. I’ve reopened. Please review again.
@youtalk why did you remove it this time?
Because no one reviews.