autoware.universe
autoware.universe copied to clipboard
fix(occupancy_grid_map_outlier_filter): add intensity field
Description
- To add intensity field for
occupancy_grid_map_outlier_filter
to solve the issue https://github.com/autowarefoundation/autoware.universe/issues/6785 - This PR will avoid fixed pointcloud type like pcl::PointXYZ or pcl::PointXYZI.
- Almost of all calculations are replaced and done directly in Pointcloud2 except kd_tree_->radiusSearch. So that the pointcloud type will be coppied through the node by reference
point_step
of input topic so that the pointcloud type which is processed and output depends and is the same as input pointcloud type.
Related links
- Releated PR: https://github.com/autowarefoundation/autoware.universe/pull/6791
Tests performed
Confirmed by logging_simulator that the intensity is added into the current empty padding fiedl (offset 12)
- Testing on the sample rosbag shows the processing time isn't affected much, even seems get slightly faster.
Before | After |
---|---|
- Here is testing result when pcl::PointXYZ pointcloud type is input into the node. It shows that the node also work well with PointXYZ type input
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
- [ ] I've confirmed the contribution guidelines.
- [ ] The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
- [ ] The PR follows the pull request guidelines.
- [ ] The PR has been properly tested.
- [ ] The PR has been reviewed by the code owners.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
- [ ] There are no open discussions or they are tracked via tickets.
- [ ] The PR is ready for merge.
After all checkboxes are checked, anyone who has write access can merge the PR.