autoware.universe
autoware.universe copied to clipboard
refactor(perception_ground_segmentation): rework parameters
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the perception_ground_segmentation
- Remove the default value from the source code in order to ensure all parameter values are passed from the parameter files.
2.create schema
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
- [ ] I've confirmed the contribution guidelines.
- [ ] The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
- [ ] The PR follows the pull request guidelines.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
- [ ] There are no open discussions or they are tracked via tickets.
After all checkboxes are checked, anyone who has write access can merge the PR.
@karishma1911
I have another comment.
Since some parameters use default values which only declared in scan_ground_filter_nodelet.cpp
so common_ground_filter
cannot started with your PR. One of the errors as below. Could you also add such missing parameters into ground_segmentation.param.yaml file also?
Failed to load node 'common_ground_filter' of type 'ground_segmentation::ScanGroundFilterComponent' in container 'pointcloud_container': Component constructor threw an exception: Statically typed parameter 'radial_divider_angle_deg' must be initialized.
This pull request has been automatically marked as stale because it has not had recent activity.
@karishma1911 Hi, thank you for your contribution! What is the status of this PR? If this is stale, can we make this PR draft for now? (Of course feel free to re-open if it's ready for review)
@karishma1911 could you please provide updates?
@karishma1911 Please fix the PR or recreate as another one :pray:
@karishma1911 Let me convert this PR as a draft as it may be noisy for other developers. But feel free to reopen this PR once it is fixed. Thank you for your contribution!