autoware.universe icon indicating copy to clipboard operation
autoware.universe copied to clipboard

fix(mission_planner): consider overlap lanelets when enable_correct_goal_pose param is true

Open beyzanurkaya opened this issue 1 year ago • 9 comments

Description

Fixes:

  • https://github.com/autowarefoundation/autoware.universe/issues/5530

Tests performed

https://github.com/autowarefoundation/autoware.universe/assets/32412808/0a0f1cc0-aeaf-4330-b0da-fc1cdae81822

wip tier4 internal scenario test evaluator_description: fix/consider-overlap-lanelet 2023/11/30 https://evaluation.tier4.jp/evaluation/reports/b059c77e-39d1-5d8c-8367-127e79619b10/?project_id=prd_jt

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • [ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

beyzanurkaya avatar Nov 09 '23 09:11 beyzanurkaya

Codecov Report

Attention: Patch coverage is 12.90323% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 14.84%. Comparing base (8948859) to head (f805b36). Report is 2 commits behind head on main.

:exclamation: Current head f805b36 differs from pull request most recent head 047170a. Consider uploading reports for the commit 047170a to get more accurate results

Files Patch % Lines
...n_planner/src/lanelet2_plugins/default_planner.cpp 11.76% 4 Missing and 11 partials :warning:
planning/route_handler/src/route_handler.cpp 14.28% 5 Missing and 7 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5533      +/-   ##
==========================================
- Coverage   14.94%   14.84%   -0.10%     
==========================================
  Files        1943     1838     -105     
  Lines      133953   126717    -7236     
  Branches    39841    37982    -1859     
==========================================
- Hits        20020    18817    -1203     
+ Misses      91656    86652    -5004     
+ Partials    22277    21248    -1029     
Flag Coverage Δ *Carryforward flag
differential 14.85% <12.90%> (?)
total 14.85% <ø> (-0.10%) :arrow_down: Carriedforward from 78eea31

*This pull request uses carry forward flags. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 09 '23 14:11 codecov[bot]

@beyzanurkaya is it ok to update this branch?

kosuke55 avatar Nov 28 '23 03:11 kosuke55

@kosuke55 sure, I rebased the branch onto main.

beyzanurkaya avatar Nov 28 '23 07:11 beyzanurkaya

@kosuke55 @beyzanurkaya

I am working on a PR also covers/solves this issue. So when I am done, I would like to review this PR as well before we possibly merge it.

mehmetdogru avatar Nov 28 '23 08:11 mehmetdogru

@beyzanurkaya @mehmetdogru thanks! I ran tier4 internal scenario test just now, I will review this after checking the result is no problem

kosuke55 avatar Nov 29 '23 15:11 kosuke55

some scenarios related shoulder_lanes fails, but I did not check closely 🙏

kosuke55 avatar Nov 30 '23 15:11 kosuke55

This pull request has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Feb 10 '24 06:02 stale[bot]

@beyzanurkaya could you resolve the conflicts and update this PR?

Do you have any blockers or questions on this PR?

xmfcx avatar Mar 05 '24 20:03 xmfcx

I would suggest to first squash, then rebase to make it easier to resolve the conflicts. You can contact me if you need help.

xmfcx avatar Mar 05 '24 20:03 xmfcx

This pull request has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Jul 06 '24 13:07 stale[bot]