autoware.universe icon indicating copy to clipboard operation
autoware.universe copied to clipboard

refactor(dummy_infrastructure): rework parameters

Open yuntianyi-chen opened this issue 1 year ago • 1 comments

Description

Refactor the ROS Node configuration layout for the dummy_infrastructure package according to the guideline.

  • Create the schema file.
  • Remove the default values from the source code to avoid duplication.
  • Update the launch file and README file.

Related links

None

Tests performed

The refactored node was successfully built and tested by launching this node individually.

Notes for reviewers

None

Interface changes

  • Create the schema file.
  • Parameter values are now required to be passed to the node when launched.

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • [x] The PR follows the pull request guidelines.
  • [x] The PR has been properly tested.
  • [x] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • [ ] There are no open discussions or they are tracked via tickets.
  • [ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

yuntianyi-chen avatar Oct 11 '23 21:10 yuntianyi-chen

This pull request has been automatically marked as stale because it has not had recent activity.

stale[bot] avatar Dec 10 '23 22:12 stale[bot]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

github-actions[bot] avatar Jul 11 '24 13:07 github-actions[bot]