autoware.universe icon indicating copy to clipboard operation
autoware.universe copied to clipboard

feat: localization evaluator

Open angry-crab opened this issue 2 years ago • 6 comments

Signed-off-by: Xinyu Wang [email protected]

Description

Localization evaluator (tested with Kitti raw dataset)

Related links

Evaluate performance of localization pipeline

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • [ ] The PR follows the pull request guidelines.
  • [ ] The PR has been properly tested.
  • [ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • [ ] There are no open discussions or they are tracked via tickets.
  • [ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

angry-crab avatar Jun 09 '22 07:06 angry-crab

Codecov Report

Merging #1066 (22eb644) into main (fb88141) will decrease coverage by 0.43%. The diff coverage is 0.00%.

:exclamation: Current head 22eb644 differs from pull request most recent head 39ed3f6. Consider uploading reports for the commit 39ed3f6 to get more accurate results

@@           Coverage Diff            @@
##            main   #1066      +/-   ##
========================================
- Coverage   9.94%   9.51%   -0.44%     
========================================
  Files       1117     973     -144     
  Lines      77941   65361   -12580     
  Branches   18117   11579    -6538     
========================================
- Hits        7752    6217    -1535     
+ Misses     62879   54063    -8816     
+ Partials    7310    5081    -2229     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.50% <ø> (-0.43%) :arrow_down: Carriedforward from a8809dd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r/include/localization_evaluator/interpolation.hpp 0.00% <0.00%> (ø)
...tion_evaluator/src/localization_evaluator_core.cpp 0.00% <0.00%> (ø)
...tion_evaluator/src/localization_evaluator_node.cpp 0.00% <0.00%> (ø)
...ator/nodes/costmap_generator/points_to_costmap.cpp 0.00% <0.00%> (-82.36%) :arrow_down:
...tor/nodes/costmap_generator/objects_to_costmap.cpp 0.00% <0.00%> (-33.34%) :arrow_down:
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 71.69% <0.00%> (-11.33%) :arrow_down:
...ene_module/occlusion_spot/occlusion_spot_utils.hpp 50.00% <0.00%> (-7.15%) :arrow_down:
...vehicle_model/sim_model_delay_steer_acc_geared.cpp 71.26% <0.00%> (-6.90%) :arrow_down:
...autoware_utils/test/src/geometry/test_geometry.cpp 35.36% <0.00%> (-5.33%) :arrow_down:
...include/tier4_autoware_utils/geometry/geometry.hpp 90.62% <0.00%> (-4.69%) :arrow_down:
... and 435 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df0b845...39ed3f6. Read the comment docs.

codecov[bot] avatar Jun 09 '22 07:06 codecov[bot]

Comments and debugging logs will be removed after review.

angry-crab avatar Jun 15 '22 05:06 angry-crab

I have talked with @angry-crab to refactor the code according to the diagram in the pdf. Uploading Localization Evaluator.pdf…

mitsudome-r avatar Jun 29 '22 08:06 mitsudome-r

The code looks good to me. Maybe we should have the following in the readme:

  • How to convert KITTI dataset into a rosbag.
  • Recommended way to use this tool (e.g., with plotjuggler) It can be done with another PR if that sounds suitable.

mitsudome-r avatar Jul 11 '22 07:07 mitsudome-r

The code looks good to me. Maybe we should have the following in the readme:

  • How to convert KITTI dataset into a rosbag.
  • Recommended way to use this tool (e.g., with plotjuggler) It can be done with another PR if that sounds suitable.

README is updated to include more detailed instructions and recommendation usage.

angry-crab avatar Jul 12 '22 06:07 angry-crab

@mitsudome-r I reverted some weird commits. Please check again. If everything looks good, I'll merge this PR. Thanks.

angry-crab avatar Jul 19 '22 23:07 angry-crab

@angry-crab are there any updates on this? It is approved but CI build seems to be failing.

xmfcx avatar Aug 09 '22 15:08 xmfcx

@angry-crab are there any updates on this? It is approved but CI build seems to be failing.

This PR will be closed because there is already a package which does the same thing. I'll create another PR to merge some features into the existing package.

angry-crab avatar Aug 16 '22 06:08 angry-crab