autoware.core icon indicating copy to clipboard operation
autoware.core copied to clipboard

feat: add autoware_simple_pure_pursuit package

Open takayuki5168 opened this issue 1 year ago • 9 comments

Description

Added a simple_pure_pursuit for the Autoware.Core's default controller

Related links

https://github.com/orgs/autowarefoundation/discussions/5365

How was this PR tested?

No tests are applied at all since the launch files are not prepared yet.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

takayuki5168 avatar Dec 24 '24 10:12 takayuki5168

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

github-actions[bot] avatar Dec 24 '24 10:12 github-actions[bot]

Documentation URL: https://autowarefoundation.github.io/autoware.core/pr-140/ Modified URLs:

  • https://autowarefoundation.github.io/autoware.core/pr-140/control/autoware_simple_pure_pursuit/

github-actions[bot] avatar Feb 25 '25 08:02 github-actions[bot]

@takayuki5168 First of all, please pass the 3 failing checks.

youtalk avatar Feb 26 '25 00:02 youtalk

@youtalk I was asked by @mitsudome-r -san to make this PR ready for review, but this PR is incomplete since the dependent packages are still in the autoware.universe, and with these changes, another CI failures may occur. That's why I ignore the minor CI failures for now. I'm fine with making this PR draft again if you want.

→ By removing the unnecessary commit, I found that the CI failure is only a build error. :smile:

takayuki5168 avatar Feb 26 '25 00:02 takayuki5168

Could you list the packages this depends that are in autoware_universe?

xmfcx avatar Feb 26 '25 07:02 xmfcx

@xmfcx I think it's only the autoware_universe_utils, and it was ported to the autoware_utils just yesterday. https://github.com/autowarefoundation/autoware_utils/pull/30

I will fix this PR based on the above changes.

takayuki5168 avatar Feb 26 '25 07:02 takayuki5168

Codecov Report

Attention: Patch coverage is 81.08108% with 21 lines in your changes missing coverage. Please review.

Project coverage is 1.66%. Comparing base (4cb18f5) to head (0de2e0a). Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
...re_simple_pure_pursuit/src/simple_pure_pursuit.cpp 81.03% 9 Missing and 2 partials :warning:
...ple_pure_pursuit/test/test_simple_pure_pursuit.cpp 81.13% 0 Missing and 10 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #140       +/-   ##
==========================================
- Coverage   78.75%   1.66%   -77.10%     
==========================================
  Files          11      65       +54     
  Lines         193    8489     +8296     
  Branches       73     824      +751     
==========================================
- Hits          152     141       -11     
- Misses         11    8328     +8317     
+ Partials       30      20       -10     
Flag Coverage Δ
differential 1.66% <81.08%> (?)
total ?

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Feb 26 '25 15:02 codecov[bot]

@xmfcx @mitsudome-r Seems that the failure of the pre-commit comes from the other package. Other than that, the required CI passed. image

takayuki5168 avatar Feb 26 '25 16:02 takayuki5168

@mitsudome-r Seems that all the required CI passed. I leave this PR to you.

takayuki5168 avatar Mar 10 '25 03:03 takayuki5168

I have tested with simple planning simulator that it can follow the planned trajectory. (It is not as accurate as mpc, but performance is not required for now)

https://github.com/user-attachments/assets/f29a3264-edb0-46b2-8d89-407d7c2389ec

mitsudome-r avatar Mar 13 '25 10:03 mitsudome-r