autoware-documentation
autoware-documentation copied to clipboard
feat: add parameter description
Signed-off-by: Takayuki Murooka [email protected]
Related links
https://github.com/autowarefoundation/autoware_launch/issues/66
Description
We will add a config/ directory in the autoware_launch
package soon.
In this PR, I added the document about what kind of parameters we have and how to manage them.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
- [x] I've confirmed the contribution guidelines.
- [x] The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
- [ ] The PR follows the pull request guidelines.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
- [ ] There are no open discussions or they are tracked via tickets.
After all checkboxes are checked, anyone who has write access can merge the PR.
Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-171/ Modified URLs:
- https://autowarefoundation.github.io/autoware-documentation/pr-171/contributing/coding-guidelines/ros-nodes/parameters/
@kenji-miyake This is a WIP PR. Could you have a brief look at this PR? Does this PR look good so far?
@takayuki5168 Could you write a bit more concrete description? :bow:
@kenji-miyake Can I merge this PR if you get your approval even though the parameter management described in this doc has not been used in autoware.
I wrote like this to notice that this is a proposal document for now.
@takayuki5168 Hmm, I think in that case we should discuss and adopt it. What is the blocker for using the parameter management method? Anyway, I'll take a look at this PR this week in more detail.
(I'm sorry for my late reply.) I've talked to @takayuki5168. We'll organize the management system of config files first, and merge this document at the same time.
The development policy is already agreed in https://github.com/autowarefoundation/autoware_launch/issues/66.
This pull request has been automatically marked as stale because it has not had recent activity.