tp-qemu block_disk_not_default_options: creates new test case

Depends on https://github.com/autotest/tp-qemu/pull/4219

block_disk_not_default_options: creates new test case

Creates a new test case that boots up a VM with a disk configured with non-common options such as packed or page-per-vq. Unplug the disk and hotplugs it again.

Signed-off-by: Mario Casquero [email protected] ID: 3007

Nov 18 '24 07:11 mcasquer

Tests results

 (1/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.q35: STARTED
 (1/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.q35: PASS (68.59 s)
 (2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.q35: STARTED
 (2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.q35: PASS (166.62 s)
 (3/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.q35: STARTED
 (3/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.q35: PASS (69.51 s)
 (4/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.q35: STARTED
 (4/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.q35: PASS (156.81 s)
RESULTS    : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Nov 18 '24 07:11 mcasquer

@qingwangrh could you review this PR? Thanks !

Nov 18 '24 08:11 mcasquer

@qingwangrh now the qtree check should be fully implemented, still working on the dd cmd improvement

Nov 21 '24 12:11 mcasquer

 (1/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (1/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (79.48 s)
 (2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (2/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (149.51 s)
 (3/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (3/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (82.51 s)
 (4/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (4/4) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (152.04 s)
RESULTS    : PASS 4 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Nov 21 '24 12:11 mcasquer

@mcasquer Please don't forget to add -S when pushing the patch. (I.E. commit signature)

Nov 27 '24 02:11 XueqiangWei

@mcasquer Please don't forget to add -S when pushing the patch. (I.E. commit signature)

Sorry for that, it's been a one-time oversight :sweat_smile:

Nov 27 '24 06:11 mcasquer

Once the dependent patch https://github.com/autotest/tp-qemu/pull/4219 gets merged, CI should be green after rebase

Nov 27 '24 06:11 mcasquer

After applying the dependent patch: RHEL 9.6 guest with virtio_scsi + virtio_blk

 (1/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (1/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (113.15 s)
 (2/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (2/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (85.06 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Win10 guest with virtio_scsi

 (1/1) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (1/1) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (197.42 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Win2025 guest with virtio_blk

 (1/1) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (1/1) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (297.07 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Nov 29 '24 07:11 mcasquer

This is a kindly reminder, @qingwangrh please could you review again this PR? Thanks !

Dec 05 '24 07:12 mcasquer

@yanan-fu @zhencliu @PaulYuuu could you also review this PR? Thanks !

Dec 05 '24 07:12 mcasquer

Added @XueqiangWei

Dec 05 '24 07:12 zhencliu

With last update on the provider:

 (1/1) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (1/1) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (79.80 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Dec 10 '24 10:12 mcasquer

After applying the dependent patch with last changes both test cases passed

 (1/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (1/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_blk.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (91.24 s)
 (2/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (2/2) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (95.52 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Jan 09 '25 13:01 mcasquer

This is a kindly reminder, please @yanan-fu @PaulYuuu could you review this PR? Thanks !

Jan 09 '25 13:01 mcasquer

@PaulYuuu please, could you review again this PR? Thanks !

Feb 11 '25 09:02 mcasquer

@mcasquer Some checks were not successful, please check them. @qingwangrh Could you please help take a look at it again? Many thanks.

Feb 11 '25 18:02 XueqiangWei

@mcasquer Some checks were not successful, please check them.

@XueqiangWei yes, that's because the dependent patch added in the summary, once it gets merged the CI should be pass

Feb 11 '25 23:02 mcasquer

Heloo @XueqiangWei any update about this PR? Thanks !

Mar 12 '25 06:03 mcasquer

@qingwangrh could you help review this PR again? Thanks !

Mar 12 '25 09:03 XueqiangWei

Hello @qingwangrh note that this patch has been updated accordingly to the dependent provider one

Mar 14 '25 06:03 mcasquer

With the dependent patch applied:

 (1/1) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (1/1) Host_RHEL.m9.u6.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.6.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (90.02 s)
RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Mar 17 '25 14:03 mcasquer

 (1/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (1/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (97.63 s)
 (2/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (2/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win11.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (207.42 s)
 (3/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: STARTED
 (3/3) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2025.x86_64.io-github-autotest-qemu.block_disk_not_default_options.with_packed_and_ppv.q35: PASS (356.18 s)
RESULTS    : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

Mar 26 '25 08:03 mcasquer

@qingwangrh could you review again this PR?

Mar 26 '25 08:03 mcasquer

LGTM

Mar 26 '25 08:03 qingwangrh

Hello @XueqiangWei any more thoughts from your side?

Mar 26 '25 08:03 mcasquer