tp-qemu icon indicating copy to clipboard operation
tp-qemu copied to clipboard

virtio_fs: use dd cmd to create file

Open xiagao opened this issue 1 year ago • 9 comments

Echo cmd sometimes cause timeout issue in automation, and the main test point isn't create files in this case, so using dd cmd to instead of echo cmd. ID: 1752

xiagao avatar Dec 18 '23 09:12 xiagao

@leidwang Could you review this patch?

xiagao avatar Jan 10 '24 05:01 xiagao

Could you add the test results here, thanks! Btw, if it is a workaround, maybe we can add an annotation here.

leidwang avatar Jan 10 '24 08:01 leidwang

Hi @xiagao

Any update about this PR?Thanks.

leidwang avatar Feb 28 '24 05:02 leidwang

Test result is passed,but update to github failed last time.

xiagao avatar Feb 28 '24 06:02 xiagao

@YongxueHong Could you please have a look at this patch? Thanks.

xiagao avatar Mar 04 '24 01:03 xiagao

Hi @xiagao As you mentioned Echo cmd sometimes cause timeout issue in automation.... Would you like to explain the reason for it? What's the root cause that results in the timeout issue? Thanks.

YongxueHong avatar Mar 04 '24 02:03 YongxueHong

Hi @xiagao As you mentioned Echo cmd sometimes cause timeout issue in automation.... Would you like to explain the reason for it? What's the root cause that results in the timeout issue? Thanks.

Hi yongxue, actually I didn't know the root cause, so I use a workaround here to test the main test point.

xiagao avatar Mar 04 '24 03:03 xiagao

Hi @xiagao As you mentioned Echo cmd sometimes cause timeout issue in automation.... Would you like to explain the reason for it? What's the root cause that results in the timeout issue? Thanks.

Hi yongxue, actually I didn't know the root cause, so I use a workaround here to test the main test point.

Got it, but I am afraid that your currency solution will hit the same issue since we did not find the root cause just use another command which is the same as the previous way(echo command). IOM, I don't think that the currency way is a workaround, A workaround is a concept that describes a short-term or temporary solution to a problem that we already know the root cause for it. Thanks.

YongxueHong avatar Mar 04 '24 05:03 YongxueHong

Hi @xiagao As you mentioned Echo cmd sometimes cause timeout issue in automation.... Would you like to explain the reason for it? What's the root cause that results in the timeout issue? Thanks.

Hi yongxue, actually I didn't know the root cause, so I use a workaround here to test the main test point.

Got it, but I am afraid that your currency solution will hit the same issue since we did not find the root cause just use another command which is the same as the previous way(echo command). IOM, I don't think that the currency way is a workaround, A workaround is a concept that describes a short-term or temporary solution to a problem that we already know the root cause for it. Thanks.

I know your concern, actually in many test loops, "echo xx" cmd always failed, but "dd xx" cmd passed. And "echo xx" would passed manually. Anyway, I think your concern makes sense, give me some time to figure out the precise root cause.

xiagao avatar Mar 04 '24 06:03 xiagao

Hi @xiagao Based on your analysis, indeed this is an automation issue, it is not related to the product, and not to block the test case, let's merge it first. BTW, Could you help to open an issue to track the root automation bug? I would like to fix it if I am free in the future. Thanks.

YongxueHong avatar Sep 02 '24 13:09 YongxueHong