tp-qemu icon indicating copy to clipboard operation
tp-qemu copied to clipboard

Published 20 hours ago • verified publisher icon autotest

virtio_serial_file_transfer: fix bidirectional transmission error

Open vivianQizhu opened this issue 1 year ago • 10 comments

Remove the usage of option 'both' of the transfer scripts, as it is not able to control the order of the sender and receiver with two side scripts. We move the logic outside so the order is 100% correct.

ID: 1931711 Signed-off-by: Qianqian Zhu [email protected]

vivianQizhu avatar Jun 15 '23 09:06 vivianQizhu

Hi @6-dehan and @nanliu-r Please help review, especially check if the test steps are expected. I have a basic test passed but it definitely require a full regression test. Thanks.

vivianQizhu avatar Jun 15 '23 09:06 vivianQizhu

the logic LGTM, but the test result still have a problem, but the original error has gone, I'll debug current issue: (01/12) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED (01/12) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (562.72 s) (02/12) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED (02/12) Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (794.66 s) (03/12) repeat1.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (03/12) repeat1.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: FAIL: Serial data transfter test failed. (252.33 s) (04/12) repeat1.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (04/12) repeat1.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: FAIL: Serial data transfter test failed. (320.35 s) (05/12) repeat2.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (05/12) repeat2.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: FAIL: Serial data transfter test failed. (202.64 s) (06/12) repeat2.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (06/12) repeat2.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: PASS (1065.85 s) (07/12) repeat3.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (07/12) repeat3.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: FAIL: Serial data transfter test failed. (200.48 s) (08/12) repeat3.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (08/12) repeat3.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: FAIL: Serial data transfter test failed. (232.83 s) (09/12) repeat4.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (09/12) repeat4.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: FAIL: Serial data transfter test failed. (1044.53 s) (10/12) repeat4.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (10/12) repeat4.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: FAIL: Serial data transfter test failed. (233.14 s) (11/12) repeat5.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (11/12) repeat5.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: FAIL: Serial data transfter test failed. (200.88 s) (12/12) repeat5.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: STARTED (12/12) repeat5.Host_RHEL.m9.u3.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35: FAIL: Serial data transfter test failed. (210.28 s)

6-dehan avatar Jun 19 '23 08:06 6-dehan

Hi @6-dehan @vivianQizhu Could you please check this patch status when you are free?

leidwang avatar Jul 19 '23 06:07 leidwang

My test all passed, suppose there is still some issue in current logic, I will run more test to debug. Thanks @6-dehan @leidwang

vivianQizhu avatar Sep 14 '23 06:09 vivianQizhu

My test all passed, suppose there is still some issue in current logic, I will run more test to debug. Thanks @6-dehan @leidwang

I'm about to test it and update result later.

6-dehan avatar Nov 02 '23 03:11 6-dehan

My test all passed, suppose there is still some issue in current logic, I will run more test to debug. Thanks @6-dehan @leidwang

I'm about to test it and update result later.

sent

6-dehan avatar Nov 02 '23 05:11 6-dehan

My test all passed, suppose there is still some issue in current logic, I will run more test to debug. Thanks @6-dehan @leidwang

I'm about to test it and update result later.

sent

@vivianQizhu All cases go well for now. I think we can merge this patch as we discussed. thanks.

(03/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.q35: STARTED (03/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.q35: PASS (161.72 s) (04/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.1_N.q35: STARTED (04/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.1_N.q35: PASS (444.34 s) (05/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.N_M.q35: STARTED (05/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.N_M.q35: PASS (560.77 s) (06/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.N_1.q35: STARTED (06/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.N_1.q35: PASS (2707.03 s) (07/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: STARTED (07/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: PASS (406.24 s) (08/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.offline_migration.q35: STARTED (08/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.offline_migration.q35: PASS (230.06 s) (09/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.q35: STARTED (09/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.q35: PASS (125.61 s) (10/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.1_N.q35: STARTED (10/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.1_N.q35: PASS (438.40 s) (11/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.N_M.q35: STARTED (11/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.N_M.q35: PASS (707.73 s) (12/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.N_1.q35: STARTED (12/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.boot_with_multiple_virtserialports.N_1.q35: PASS (3047.19 s) (13/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: STARTED (13/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.max_ports.q35: PASS (427.66 s) (14/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.offline_migration.q35: STARTED (14/14) Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.offline_migration.q35: PASS (254.21 s)

6-dehan avatar Nov 02 '23 15:11 6-dehan

@nanliu-r Would you please help review? Thanks.

vivianQizhu avatar Nov 10 '23 07:11 vivianQizhu

@nanliu-r Would you please help review? Thanks.

Hi, I met the a few cases failed because of error '.exceptions.TestFail: Test failed. The script output is empty, not terminate as expected', will debug to check if this is logic issue soon.

nanliu-r avatar Nov 13 '23 01:11 nanliu-r

@vivianQizhu Hi, there are still some issues failed because of error '.exceptions.TestFail: Test failed. The script output is empty, not terminate as expected', could you please help check this? Thanks.

01-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.unix_socket.q35 07-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.tcp_socket.q35 08-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_serial_file_transfer.pty.q35 10-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_port_hotplug.unplug_chardev.q35 11-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_port_hotplug.q35 12-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_port_hotplug.with_bg_test.q35 23-Host_RHEL.m9.u4.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2022.x86_64.io-github-autotest-qemu.virtio_port_hotplug.hotplug_port_pci.max_chardevs.q35

nanliu-r avatar Nov 15 '23 07:11 nanliu-r