tp-qemu icon indicating copy to clipboard operation
tp-qemu copied to clipboard

memhp_threads: Update check point for prealloc-threads default

Open zhenyzha opened this issue 2 years ago • 1 comments

Some old version rhel8 hosts will create a thread when adding one memory-backend-file default, but the thread creation is not due to the setting of the qemu source code. We can see that before qemu7.1 on rhel9, adding a memory-backend-file default will not create one thread. This was fixed after qemu7.1, anyway, Our test point is that after 7.1, the default value of the thread is equal to the number of smps, so as to achieve performance improvement. So remove pre-7.1 default checks.

ID: 2152530 Signed-off-by: zhenyzha [email protected]

zhenyzha avatar Dec 12 '22 11:12 zhenyzha

 (1/2) Host_RHEL.m8.u6.product_rhel.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.6.0.x86_64.io-github-autotest-qemu.memhp_threads.q35: PASS (73.62 s)
 (2/2) Host_RHEL.m8.u6.product_rhel.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.memhp_threads.q35: PASS (159.07 s)

@mcasquer @YongxueHong Could you pls help review when you are free. thanks.

zhenyzha avatar Dec 12 '22 12:12 zhenyzha

Tested on RHEL9.0.0, RHEL.8.6.0 and Win2019 guests.

Before applying the patch:

 (1/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.6.0.x86_64.io-github-autotest-qemu.memhp_threads.q35: STARTED
 (1/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.6.0.x86_64.io-github-autotest-qemu.memhp_threads.q35: FAIL: QEMU threads number is not right, pre is 8, post is 9 (21.45 s)
 (2/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.0.0.x86_64.io-github-autotest-qemu.memhp_threads.q35: STARTED
 (2/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.0.0.x86_64.io-github-autotest-qemu.memhp_threads.q35: FAIL: QEMU threads number is not right, pre is 8, post is 9 (21.21 s)
 (3/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.memhp_threads.q35: STARTED
 (3/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.memhp_threads.q35: FAIL: QEMU threads number is not right, pre is 8, post is 9 (21.21 s)
RESULTS    : PASS 0 | ERROR 0 | FAIL 3 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

After applying the patch:

[root@dell-per750-24 io-github-autotest-qemu]# git am 3562.patch
Applying: memhp_threads: Update check point for prealloc-threads default

Auto case passed successfully in all guests:

 (1/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.6.0.x86_64.io-github-autotest-qemu.memhp_threads.q35: STARTED
 (1/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.8.6.0.x86_64.io-github-autotest-qemu.memhp_threads.q35: PASS (67.91 s)
 (2/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.0.0.x86_64.io-github-autotest-qemu.memhp_threads.q35: STARTED
 (2/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9.0.0.x86_64.io-github-autotest-qemu.memhp_threads.q35: PASS (64.54 s)
 (3/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.memhp_threads.q35: STARTED
 (3/3) Host_RHEL.m9.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.memhp_threads.q35: PASS (192.71 s)
RESULTS    : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0

mcasquer avatar Dec 14 '22 08:12 mcasquer

@YongxueHong Could you pls help review when you are free. thanks.

zhenyzha avatar Jan 05 '23 01:01 zhenyzha