tp-libvirt icon indicating copy to clipboard operation
tp-libvirt copied to clipboard

virtio_page_per_vq: select input device on type

Open smitterl opened this issue 10 months ago • 3 comments

Depends on https://github.com/avocado-framework/avocado-vt/pull/3890

The tests statically selected the input element of various by its expected list index. This failed if the domain xml was different.

Select now the input element by its type and the expected driver subelement to avoid relying on order which is not defined by the XML schema here.

Finally, print more info to log for easier debugging.

smitterl avatar Apr 11 '24 07:04 smitterl

JOB ID     : 5649f1c192c289ae86020a6b7f70727c9352fc92
JOB LOG    : /var/lib/avocado/job-results/job-2024-04-11T03.33-5649f1c/job.log
 (01/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.disk.default_start: PASS (51.55 s)
 (02/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.disk.hotplug: PASS (52.39 s)
 (03/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.controller.scsi.default_start: PASS (51.80 s)
 (04/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.controller.scsi.hotplug: PASS (56.72 s)
 (05/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.controller.serial.default_start: PASS (51.46 s)
 (06/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.interface.default_start: PASS (58.42 s)
 (07/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.interface.hotplug: PASS (53.02 s)
 (08/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.rng.default_start: PASS (56.73 s)
 (09/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.rng.hotplug: PASS (52.79 s)
 (10/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.memballoon.default_start: PASS (58.15 s)
 (11/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.keyboard.default_start: PASS (58.01 s)
 (12/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.keyboard.hotplug: PASS (53.01 s)
 (13/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.mouse.default_start: PASS (56.76 s)
 (14/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.mouse.hotplug: PASS (52.18 s)
 (15/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.tablet.default_start: PASS (58.25 s)
 (16/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.tablet.hotplug: PASS (52.38 s)
 (17/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.passthrough.default_start: PASS (55.51 s)
 (18/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.passthrough.hotplug: PASS (56.98 s)
 (19/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.video.default_start: PASS (55.90 s)
 (20/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.filesystem.default_start: PASS (63.68 s)
 (21/21) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.filesystem.hotplug: PASS (62.58 s)
RESULTS    : PASS 21 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2024-04-11T03.33-5649f1c/results.html
JOB TIME   : 1171.09 s

smitterl avatar Apr 11 '24 07:04 smitterl

@meinaLi please help review

smitterl avatar Apr 11 '24 07:04 smitterl

Thank you for your review @chunfuwen and @cliping Based on feedback from @chloerh I decided to select the device not relying on XML order at all but checking the presence of the expected 'driver' subelement early. Please could you review again? Sorry for the churn.

JOB ID     : 969e0121b1782d00980acfdd904327eed05f7094
JOB LOG    : /var/lib/avocado/job-results/job-2024-04-12T07.46-969e012/job.log
 (01/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.disk.hotplug: PASS (49.92 s)
 (02/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.controller.scsi.hotplug: PASS (56.56 s)
 (03/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.interface.hotplug: PASS (52.69 s)
 (04/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.rng.hotplug: PASS (49.50 s)
 (05/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.keyboard.default_start: PASS (57.83 s)
 (06/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.keyboard.hotplug: PASS (49.47 s)
 (07/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.mouse.hotplug: PASS (49.77 s)
 (08/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.tablet.hotplug: PASS (50.81 s)
 (09/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.input.passthrough.hotplug: PASS (50.53 s)
 (10/10) type_specific.io-github-autotest-libvirt.virtio_attributes.virtio_page_per_vq.filesystem.hotplug: PASS (61.04 s)
RESULTS    : PASS 10 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2024-04-12T07.46-969e012/results.html
JOB TIME   : 530.21 s

Note: the XML order of input elements is not restricted, ref. https://gitlab.com/libvirt/libvirt/-/blob/master/src/conf/schemas/domaincommon.rng?ref_type=heads#L6028

smitterl avatar Apr 12 '24 11:04 smitterl