tp-libvirt icon indicating copy to clipboard operation
tp-libvirt copied to clipboard

Published 20 hours ago • verified publisher icon autotest

backingchain: add case to check mirror xml after restart service

Open meinaLi opened this issue 2 years ago • 3 comments

This PR adds: VIRT-294570 - [blockcommit/blockcopy][mirroring] Restart libvirtd and check xml during mirror phase of blockcommit

# avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 backingchain.lifecycle_test.check_mirror_with_restart_libvirtd
JOB ID     : 16471284d66a68113ad523b2ac29cf45de41fa18
JOB LOG    : /var/lib/avocado/job-results/job-2022-12-01T02.30-1647128/job.log
 (1/2) type_specific.io-github-autotest-libvirt.backingchain.lifecycle_test.check_mirror_with_restart_libvirtd.blockcommit: PASS (79.90 s)
 (2/2) type_specific.io-github-autotest-libvirt.backingchain.lifecycle_test.check_mirror_with_restart_libvirtd.blockcopy: PASS (80.19 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2022-12-01T02.30-1647128/results.html
JOB TIME   : 161.80 s

Signed-off-by: Meina Li [email protected]

meinaLi avatar Dec 01 '22 07:12 meinaLi

label: modular_redesign

meinaLi avatar Dec 01 '22 07:12 meinaLi

@nanli1 could you please review this pr? Thanks!

Yingshun avatar Dec 01 '22 09:12 Yingshun

Others LGTM

nanli1 avatar Dec 09 '22 08:12 nanli1

@Yingshun Would you also help to review this PR? Thanks.

meinaLi avatar Dec 15 '22 05:12 meinaLi

Could we rename the folder name from lifecycle_test to lifecycle in libvirt/tests/cfg/backingchain/lifecycle_test/check_mirror_with_restart_libvirtd.cfg libvirt/tests/src/backingchain/lifecycle_test/check_mirror_with_restart_libvirtd.py

Meina and I had different opinions for this ever . I think test word is a little common and non actual meaningful , and we seldom use test in auto case name. Sorry ,I didn't get this thought when I check the structure sheet,but get this when auto some cases. @meinaLi I forget you reason ,Please help to give comment.

@xuesong-zhang @dzhengfy @Yingshun Could you help to give opinion

nanli1 avatar Dec 21 '22 11:12 nanli1

The test plan directly use lifecycle_test as a chapter. For consistency, I also used lifecycle_test as a directory name in auto cases.

meinaLi avatar Dec 27 '22 02:12 meinaLi

#> Could we rename the folder name from lifecycle_test to lifecycle in libvirt/tests/cfg/backingchain/lifecycle_test/check_mirror_with_restart_libvirtd.cfg libvirt/tests/src/backingchain/lifecycle_test/check_mirror_with_restart_libvirtd.py

Meina and I had different opinions for this ever . I think test word is a little common and non actual meaningful , and we seldom use test in auto case name. Sorry ,I didn't get this thought when I check the structure sheet,but get this when auto some cases. @meinaLi I forget you reason ,Please help to give comment.

@xuesong-zhang @dzhengfy @Yingshun Could you help to give opinion

Similar to https://github.com/autotest/tp-libvirt/pull/4633#issuecomment-1366339390,

dzhengfy avatar Dec 28 '22 03:12 dzhengfy