tp-libvirt icon indicating copy to clipboard operation
tp-libvirt copied to clipboard

virtual_disk: remove auth checking for block lun disk

Open meinaLi opened this issue 2 years ago • 9 comments

For previous virtual_disks.scsi3_persistent_reservation.reservations_managed..enable_auth.auth_usage.auth_in_source, it's actually invalid to test auth feature in this block lun disk with reservation. In order to reduce misleading when debugging, the auth checking has been removed in this PR.

Signed-off-by: Meina Li [email protected]

meinaLi avatar Nov 09 '22 08:11 meinaLi

# avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 virtual_disks.scsi3_persistent_reservation.reservations_managed
B LOG    : /var/lib/avocado/job-results/job-2022-11-09T03.33-b8a0545/job.log
 (1/2) type_specific.io-github-autotest-libvirt.virtual_disks.scsi3_persistent_reservation.reservations_managed.hotplug_disk: PASS (149.00 s)
 (2/2) type_specific.io-github-autotest-libvirt.virtual_disks.scsi3_persistent_reservation.reservations_managed.coldplug_disk: PASS (149.64 s)
RESULTS    : PASS 2 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2022-11-09T03.33-b8a0545/results.html
JOB TIME   : 310.75 s

meinaLi avatar Nov 09 '22 08:11 meinaLi

@meinaLi , please also paste test result after code change

chunfuwen avatar Nov 21 '22 07:11 chunfuwen

# avocado run --vt-type libvirt --test-runner=runner --vt-machine-type q35 virtual_disks.scsi3_persistent_reservation.reservations_managed
JOB ID     : b3102e1c577b1792b9e64c29c3d981ec05bdf5cd
JOB LOG    : /var/lib/avocado/job-results/job-2022-11-21T03.16-b3102e1/job.log
 (01/10) type_specific.io-github-autotest-libvirt.virtual_disks.scsi3_persistent_reservation.reservations_managed.hotplug_disk.enable_auth.auth_uuid.auth_in_source: PASS (153.00 s)
 (02/10) type_specific.io-github-autotest-libvirt.virtual_disks.scsi3_persistent_reservation.reservations_managed.hotplug_disk.enable_auth.auth_uuid.auth_out_source: PASS (144.88 s)
......
 (09/10) type_specific.io-github-autotest-libvirt.virtual_disks.scsi3_persistent_reservation.reservations_managed.coldplug_disk.enable_auth.auth_usage.auth_out_source: PASS (150.34 s)
 (10/10) type_specific.io-github-autotest-libvirt.virtual_disks.scsi3_persistent_reservation.reservations_managed.coldplug_disk.disable_auth: PASS (149.06 s)
RESULTS    : PASS 10 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2022-11-21T03.16-b3102e1/results.html
JOB TIME   : 1482.81 s

meinaLi avatar Nov 21 '22 08:11 meinaLi

@meinaLi Does this pr depend on https://github.com/avocado-framework/avocado-vt/pull/3561?

dzhengfy avatar Nov 22 '22 07:11 dzhengfy

@meinaLi , please also provide both test result on RHEL8 and 9

dzhengfy avatar Nov 22 '22 07:11 dzhengfy

@dzhengfy This PR is not depended on https://github.com/avocado-framework/avocado-vt/pull/3561. And I also think there's no effect on different RHEL.

meinaLi avatar Nov 22 '22 07:11 meinaLi

In finally(), there is code to cleanup secret, which could be removed at the same time

        # Clean up secret
        if secret_uuid:
            virsh.secret_undefine(secret_uuid)

lento-sun avatar Nov 22 '22 08:11 lento-sun

@meinaLi Do you have jenkins test result updated ? @dzhengfy please check whether you can approve this PR now

chunfuwen avatar Nov 29 '22 00:11 chunfuwen

@meinaLi Do you have jenkins test result updated ? @dzhengfy please check whether you can approve this PR now

Waiting for @meinaLi jenkins test result

dzhengfy avatar Nov 30 '22 03:11 dzhengfy

This PR is passed in RHEL8 and RHEL9.

meinaLi avatar Dec 20 '22 01:12 meinaLi