tp-libvirt icon indicating copy to clipboard operation
tp-libvirt copied to clipboard

pcie, new case for invalid PCIe slots

Open vasekhodina opened this issue 2 years ago • 3 comments

This case adds checks for devices attached to PCIe controller that have slot number bigger than one or something else than a number.

VIRT-48333

vasekhodina avatar Nov 03 '22 09:11 vasekhodina

Test results from RHEL 9.2: image

vasekhodina avatar Nov 07 '22 12:11 vasekhodina

@dzhengfy Please review this PR. Thank you.

vasekhodina avatar Nov 07 '22 12:11 vasekhodina

Please hold on this pr before the https://github.com/autotest/tp-libvirt/pull/4573 is merged because there is a critical update required. See https://github.com/autotest/tp-libvirt/pull/4573#discussion_r1016406856. @vasekhodina if you do not mind, could we change it to draft for now?

dzhengfy avatar Nov 21 '22 07:11 dzhengfy

Test results from RHEL 9.2:

]# avocado run --vt-type libvirt pcie_root_port_controller
No python imaging library installed. Screendump and Windows guest BSOD detection are disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
No python imaging library installed. PPM image conversion to JPEG disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
JOB ID     : b9c62cb1f8fb3897166f710c893496d4d95d3ef0
JOB LOG    : /var/lib/avocado/job-results/job-2022-12-20T09.57-b9c62cb/job.log
 (1/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.positive_test.controllers_different_chassis_same_port: STARTED
 (1/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.positive_test.controllers_different_chassis_same_port: PASS (54.48 s)
 (2/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.device_slot_invalid: STARTED
 (2/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.device_slot_invalid: PASS (6.09 s)
 (3/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.device_slot_wrong_number: STARTED
 (3/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.device_slot_wrong_number: PASS (6.12 s)
 (4/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.controllers_same_chassis_same_port: STARTED
 (4/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.controllers_same_chassis_same_port: PASS (7.40 s)
 (5/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.controllers_same_chassis_different_port: STARTED
 (5/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.controllers_same_chassis_different_port: PASS (8.09 s)
 (6/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.index_equals_address_bus: STARTED
 (6/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.index_equals_address_bus: PASS (5.92 s)
 (7/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.index_less_than_address_bus: STARTED
 (7/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.index_less_than_address_bus: PASS (5.95 s)
RESULTS    : PASS 7 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2022-12-20T09.57-b9c62cb/results.html
JOB TIME   : 102.15 s

vasekhodina avatar Dec 20 '22 15:12 vasekhodina

@vasekhodina please rebase.

dzhengfy avatar Jan 13 '23 07:01 dzhengfy

Tests still pass even after latest changes:

# avocado run --vt-type libvirt pcie_root_port_controller
No python imaging library installed. Screendump and Windows guest BSOD detection are disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
No python imaging library installed. PPM image conversion to JPEG disabled. In order to enable it, please install python-imaging or the equivalent for your distro.
JOB ID     : 286a4f1ada49d52446133e3b14f8a0ccb94e974c
JOB LOG    : /var/lib/avocado/job-results/job-2023-01-31T07.10-286a4f1/job.log
 (1/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.positive_test.controllers_different_chassis_same_port: STARTED
 (1/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.positive_test.controllers_different_chassis_same_port: PASS (84.06 s)
 (2/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.device_slot_invalid: STARTED
 (2/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.device_slot_invalid: PASS (27.85 s)
 (3/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.device_slot_wrong_number: STARTED
 (3/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.device_slot_wrong_number: PASS (15.91 s)
 (4/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.controllers_same_chassis_same_port: STARTED
 (4/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.controllers_same_chassis_same_port: PASS (17.49 s)
 (5/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.controllers_same_chassis_different_port: STARTED
 (5/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.controllers_same_chassis_different_port: PASS (28.35 s)
 (6/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.index_equals_address_bus: STARTED
 (6/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.index_equals_address_bus: PASS (14.56 s)
 (7/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.index_less_than_address_bus: STARTED
 (7/7) type_specific.io-github-autotest-libvirt.pcie_root_port_controller.negative_test.index_less_than_address_bus: PASS (14.44 s)
RESULTS    : PASS 7 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB HTML   : /var/lib/avocado/job-results/job-2023-01-31T07.10-286a4f1/results.html

vasekhodina avatar Jan 31 '23 12:01 vasekhodina