donkeycar icon indicating copy to clipboard operation
donkeycar copied to clipboard

Added info overlay part

Open JoeSiu opened this issue 4 years ago • 4 comments

a simple Info overlay that adds texts overlay to the camera images, might be useful for debugging. It can show the current fps if enabled (#897) as well as the current throttle and angle, or any other info by adding the inputs or by calling the 'add' function in InfoOverlayLogger.

JoeSiu avatar Jul 13 '21 09:07 JoeSiu

@JoeSiu - thanks for your PR. Why would you want to put this data into the images, as they are used for training. This would distort the ability to learn. You have another PR where the car frequency data gets logged. This is more useful I think.

DocGarbanzo avatar Jul 18 '21 11:07 DocGarbanzo

@DocGarbanzo This part is mainly used for easier debugging. For example, when testing the stop sign detection, It's easier to see the current pilot's throttle as well as the bounding box for the stop sign directly on the camera image while using the mobile app or web controller, instead of checking the output from the shell in a separate window which I think is less convenient. It will indeed affect the training through which I didn't consider at first, sorry about that!

JoeSiu avatar Jul 23 '21 08:07 JoeSiu

@JoeSiu - thanks for addressing / solving all change requests. This looks very good to me now. Can you please do one last step and that is rebasing your branch on dev (this will require resolving some conflicts as complete.py got updated in the meantime), squashing your 3 commits into 1 and then force pushing your branch? This will create a single commit into the repo that keeps the history linear & I can merge this.

DocGarbanzo avatar Aug 05 '21 15:08 DocGarbanzo

@DocGarbanzo I have rebased the branch, thank you!

JoeSiu avatar Aug 06 '21 04:08 JoeSiu