donkeycar icon indicating copy to clipboard operation
donkeycar copied to clipboard

Add datastore metadata function and test

Open sctse999 opened this issue 4 years ago • 5 comments

sctse999 avatar Feb 03 '21 03:02 sctse999

Codecov Report

Merging #782 (8caa10b) into dev (a35ef33) will increase coverage by 0.02%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #782      +/-   ##
==========================================
+ Coverage   29.46%   29.49%   +0.02%     
==========================================
  Files          66       66              
  Lines        7985     7988       +3     
  Branches      839      839              
==========================================
+ Hits         2353     2356       +3     
- Misses       5512     5513       +1     
+ Partials      120      119       -1     
Impacted Files Coverage Δ
donkeycar/parts/datastore_v2.py 92.30% <33.33%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a35ef33...8caa10b. Read the comment docs.

codecov-io avatar Feb 03 '21 04:02 codecov-io

E.g. allowing user to put remarks on a dataset (we allow this on the app)

sctse999 avatar Feb 03 '21 15:02 sctse999

Lets hold off on making this change. There are a few things I want to change before we land this.

tikurahul avatar Feb 04 '21 17:02 tikurahul

Just wondering when this could get merged?

sctse999 avatar Mar 13 '21 15:03 sctse999

Actually i thought more about this, and I don't want to add this feature to the Tub itself. This is because metadata is already a very overloaded term.

You can keep this data in a separate file, and correlate it with the session_id.

tikurahul avatar Mar 13 '21 16:03 tikurahul