added speed return for simulator in dgym.py

Open wallarug opened this issue 5 years ago • 5 comments

as stated.

Does have changes that stop compatibility with other manage.py templates. Going forward - everyone should use simulator.py template to ensure all new simulator changes are implemented and working.

Oct 25 '20 06:10 wallarug

Does this work with the official simulator?

Oct 25 '20 06:10 sctse999

Absolutely. No simulator changes were required. It was already implemented in Unity just not in the DonkeyGymEnv (which it is now).

Oct 25 '20 07:10 wallarug

The Travis failure is w.r.t the training convergence which we have already scheduled to take out of travis, everything else passes. Looks good to me otherwise.

Oct 26 '20 21:10 DocGarbanzo

Great! Thanks @DocGarbanzo 👍 .

Oct 28 '20 08:10 wallarug

@wallarug - is this still a relevant PR? This is related to #583.

Jan 16 '21 20:01 DocGarbanzo