download.MSCompanyPortal broken because of upstream issue

[kevinmcox]

Opening an issue just in case anyone comes looking for help on this.

com.github.autopkg.download.MSCompanyPortal currently doesn't work due to bad XML upstream at Microsoft. https://officecdn.microsoft.com/pr/C1297A47-86C4-4C1F-97FA-950631F94777/MacAutoupdate/0409IMCP01.xml

The string that MSOfficeMacURLandUpdateInfoProvider.py extracts from the XML for the download URL has a hard return and spaces in it, causing an error: curl: (3) URL rejected: Malformed input to a URL function

autopkg run com.github.autopkg.download.MSCompanyPortal -vv
Looking for com.github.autopkg.download.MSCompanyPortal...
Found com.github.autopkg.download.MSCompanyPortal in recipe map
Looking for com.github.autopkg.download.MSOfficeMacProduct...
Found com.github.autopkg.download.MSOfficeMacProduct in recipe map
**load_recipe time: 0.0006714590126648545
Processing com.github.autopkg.download.MSCompanyPortal...
WARNING: com.github.autopkg.download.MSCompanyPortal is missing trust info and FAIL_RECIPES_WITHOUT_TRUST_INFO is not set. Proceeding...
MSOfficeMacURLandUpdateInfoProvider
{'Input': {'channel': 'Production',
           'locale_id': '1033',
           'product': 'CompanyPortal',
           'version': 'latest'}}
MSOfficeMacURLandUpdateInfoProvider: No value supplied for munki_required_update_name, setting default value of:
MSOfficeMacURLandUpdateInfoProvider: Requesting xml: https://officecdn.microsoft.com/pr/C1297A47-86C4-4C1F-97FA-950631F94777/MacAutoupdate/0409IMCP01.xml
MSOfficeMacURLandUpdateInfoProvider: Found URL
                https://officecdnmac.microsoft.com/pr/C1297A47-86C4-4C1F-97FA-950631F94777/MacAutoupdate/CompanyPortal_5.2401.0-Upgrade.pkg
MSOfficeMacURLandUpdateInfoProvider: Got update: 'Company Portal Update 5.2401.0'
MSOfficeMacURLandUpdateInfoProvider: Extracting version 53.2401506.002 from metadata 'Update Version' key
MSOfficeMacURLandUpdateInfoProvider: Extracting version 53.2401506.002 from metadata 'Update Version' key
MSOfficeMacURLandUpdateInfoProvider: Additional pkginfo: {'minimum_os_version': '10.15', 'installs': [{'CFBundleVersion': '53.2401506.002', 'path': '/Applications/Company Portal.app', 'type': 'application'}]}
{'Output': {'additional_pkginfo': {'installs': [{'CFBundleVersion': '53.2401506.002',
                                                 'path': '/Applications/Company '
                                                         'Portal.app',
                                                 'type': 'application'}],
                                   'minimum_os_version': '10.15'},
            'minimum_os_version': '10.15',
            'url': '\n'
                   '                '
                   'https://officecdnmac.microsoft.com/pr/C1297A47-86C4-4C1F-97FA-950631F94777/MacAutoupdate/CompanyPortal_5.2401.0-Upgrade.pkg',
            'version': '53.2401506.002'}}
URLDownloader
{'Input': {'filename': 'CompanyPortal-53.2401506.002.pkg',
           'url': '\n'
                  '                '
                  'https://officecdnmac.microsoft.com/pr/C1297A47-86C4-4C1F-97FA-950631F94777/MacAutoupdate/CompanyPortal_5.2401.0-Upgrade.pkg'}}
URLDownloader: No value supplied for prefetch_filename, setting default value of: False
URLDownloader: No value supplied for CHECK_FILESIZE_ONLY, setting default value of: False
URLDownloader: ERROR: (3) URL rejected: Malformed input to a URL function

curl: (3) URL rejected: Malformed input to a URL function

Failed.
Receipt written to /Users/kevin.cox/Library/AutoPkg/Cache/com.github.autopkg.download.MSCompanyPortal/receipts/com.github.autopkg.download-receipt-20240216-170902.plist

The following recipes failed:
    com.github.autopkg.download.MSCompanyPortal
        Error in com.github.autopkg.download.MSCompanyPortal: Processor: URLDownloader: Error: curl: (3) URL rejected: Malformed input to a URL function

Nothing downloaded, packaged or imported.