recipes icon indicating copy to clipboard operation
recipes copied to clipboard

package receipt not valid mechanism for Adobe Reader

Open TomBoehm opened this issue 6 months ago • 7 comments

If Installed via autopkg or via download from Adobe Website we get:

com.adobe.acrobat.DC.reader.app.pkg.MUI
com.adobe.acrobat.DC.reader.appsupport.pkg.MUI

If updated via Adobe Updater the receipt is: com.adobe.acrobat.AcroRdrDCUpd2300820458_MUI the above receipts remain the old version

I think we should determine the Version via Acrobat\ Reader.app/Contents/Info.plist - CFBundleVersion

TomBoehm avatar Jan 09 '24 16:01 TomBoehm

If you update the package with a different source (such as Adobe Updater), the Autopkg recipe isn't at fault here. The recipe is fetching an Adobe Reader package from a specific source and importing it into your software deployment system (Munki, Jamf, etc.). It's doing so correctly, by its terms.

I agree that generally speaking, package receipts should not be relied upon for detecting versions for Adobe software, since they historically don't use them in a safe way. But how your software deployment tool deals with this is beyond AutoPkg's scope.

What would change in the behavior if the recipe used the app version to determine its own version string?

On Tue, Jan 9, 2024 at 8:09 AM TomBoehm @.***> wrote:

If Installed via autopkg or via download from Adobe Website we get:

com.adobe.acrobat.DC.reader.app.pkg.MUI com.adobe.acrobat.DC.reader.appsupport.pkg.MUI

If updated via Adobe Updater the receipt is: com.adobe.acrobat.AcroRdrDCUpd2300820458_MUI the above receipts remain the old version

I think we should determine the Version via Acrobat
Reader.app/Contents/Info.plist - CFBundleVersion

— Reply to this email directly, view it on GitHub https://github.com/autopkg/recipes/issues/479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJFTXY3P27N337PZ6OJXZLYNVTUTAVCNFSM6AAAAABBTLDJCKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3TENRYG42TGMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Nick McSpadden @.***

nmcspadden avatar Jan 09 '24 16:01 nmcspadden

Perhaps the OP is asking for a change to the munki recipe?

gregneagle avatar Jan 09 '24 17:01 gregneagle

change to the munki recipe - is correct in the munki pkginfo ... from matching :

<key>receipts</key>
<array>
<dict>
<key>packageid</key>
<key>version</key>
.......
</dict>

to focus on the app itself:

<key>installs</key>
<array>
<dict>
<key>CFBundleIdentifier</key>
<key>path</key>
......
</dict>

TomBoehm avatar Jan 09 '24 19:01 TomBoehm

One could probably use the MunkiInstallsItemsCreator processor to generate that installs array. Pull Requests accepted!

gregneagle avatar Jan 09 '24 21:01 gregneagle

the munki recipe is generating the installs item:

	<key>installs</key>
	<array>
		<dict>
			<key>CFBundleIdentifier</key>
			<string>com.adobe.Reader</string>
			<key>CFBundleName</key>
			<string>Acrobat Reader</string>
			<key>CFBundleShortVersionString</key>
			<string>23.008.20470</string>
			<key>CFBundleVersion</key>
			<string>23.008.20470</string>
			<key>minosversion</key>
			<string>10.15</string>
			<key>path</key>
			<string>/Applications/Adobe Acrobat Reader.app</string>
			<key>type</key>
			<string>application</string>
			<key>version_comparison_key</key>
			<string>CFBundleShortVersionString</string>
		</dict>
	</array>

just testet it.

or am I getting it wrong here ?

jannheider avatar Jan 31 '24 20:01 jannheider

So, @TomBoehm , what's the actual problem here?

gregneagle avatar Jan 31 '24 23:01 gregneagle

Looks great ;-)

TomBoehm avatar Feb 01 '24 15:02 TomBoehm