keeleysam-recipes icon indicating copy to clipboard operation
keeleysam-recipes copied to clipboard

Published 20 hours ago • verified publisher icon autopkg

Receipteditor fix

Open vmiller opened this issue 2 years ago • 5 comments

This should fix issue #148

vmiller avatar Aug 28 '22 23:08 vmiller

Bump

n8felton avatar Sep 29 '22 15:09 n8felton

@n8felton Check out the discussion here:

https://github.com/autopkg/keeleysam-recipes/issues/148#issuecomment-1242569230

All of the effort has been put towards migrating to the new core processor, so this PR probably isn't necessary anymore.

flammable avatar Sep 29 '22 15:09 flammable

Looks like I'm running into this issue, which is now pending this commit to get merged out of dev.

I wonder if accepting this PR is a good middle ground until upstream is worked out.

n8felton avatar Sep 29 '22 16:09 n8felton

IMHO, merging this PR would mask the problem, since all of the recipes would immediately start working. If there's a way to deprecate processors (sort of like DeprecationWarning), that'd be ideal.

flammable avatar Sep 29 '22 16:09 flammable

What I did to work around https://github.com/autopkg/autopkg/issues/827 with the core processor as it is in the current release is to add a StopProcessingIf step to stop the recipe if nothing is imported. Example here https://github.com/autopkg/vmiller-recipes/blob/master/Sassafras/SassafrasClient.munki.recipe

vmiller avatar Sep 29 '22 17:09 vmiller