keeleysam-recipes icon indicating copy to clipboard operation
keeleysam-recipes copied to clipboard

FileZilla download failing

Open eshirk opened this issue 3 years ago • 5 comments

I think the download URL may have changed, but the regex is eluding me. The current download URL is:

https://dl2.cdn.filezilla-project.org/client/FileZilla_3.58.0_macosx-x86.tar.bz2?h=B3vS3yBN3FjpFmGhmPZm_A&x=1644876098

eshirk avatar Feb 14 '22 21:02 eshirk

Someone just bought this up in MacAdmins slack, the code to fix it required adding the -x86 at the end of the file name, and removing the .app from the extension

<key>RE_PATTERN</key> <string>&lt;a href=\"(?P&lt;url&gt;http[s]?.*?(?P&lt;filename&gt;FileZilla_(?P&lt;version&gt;[\d.]+)_macosx-x86.*?\.tar\.bz2).*?)\"</string>

donaldanixon avatar Feb 15 '22 09:02 donaldanixon

I’m getting this error. Anyone else?

Error in local.munki.FileZilla: Processor: URLTextSearcher: Error: No match found on URL: https://filezilla-project.org/download.php?show_all=1

Cetartiodactyla avatar Feb 18 '22 16:02 Cetartiodactyla

I’m getting this error. Anyone else?

Error in local.munki.FileZilla: Processor: URLTextSearcher: Error: No match found on URL: https://filezilla-project.org/download.php?show_all=1

The fix is posted by @ResidentChief

Any update when the regex will get patched publicly?

Thanks!

fmiskic avatar Feb 22 '22 15:02 fmiskic

The fix is implemented in these two pull requests: https://github.com/autopkg/keeleysam-recipes/pull/143, https://github.com/autopkg/keeleysam-recipes/pull/144

@keeleysam - Could you merge one of those?

homebysix avatar Feb 22 '22 16:02 homebysix

Hi everyone !

New download URL, macosx became macos :

<key>RE_PATTERN</key> <string>&lt;a href=\"(?P&lt;url&gt;http[s]?.*?(?P&lt;filename&gt;FileZilla_(?P&lt;version&gt;[\d.]+)_macos-x86.*?\.tar\.bz2).*?)\"</string>

Can we think of an option in the recipe to give choice of the arch ? x86 vs arm64

Darkomen78 avatar Jan 03 '24 10:01 Darkomen78